Added delete namespace to uninstall process #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellistarn
reviewed
Jun 16, 2021
Makefile
Outdated
| @@ -42,16 +42,19 @@ licenses: ## Verifies dependency licenses and requires GITHUB_TOKEN to be set | |||
| go build $(GOFLAGS) -o karpenter cmd/controller/main.go | |||
| golicense hack/license-config.hcl karpenter | |||
|
|
|||
| ## Assumes developer is working with AWS. Remove line 52 if you are not working with AWS. | |||
There was a problem hiding this comment.
I'd remove this comment. It's not really tenable to ask users to modify makefiles locally. We will need a better solution for other clouds, let's solve it when we get there. Further, this doesn't actually break anything if you're not on AWS, it just applies a bogus annotation that does nothing.
In the long run, we might want to do something like check if CLOUD_PROVIDER is AWS and do something special, but let's hold off for now.
ellistarn
reviewed
Jun 16, 2021
ellistarn
approved these changes
Jun 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.