Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mutating webhook that doesn't do anything #4233

Closed
wants to merge 4 commits into from
Closed

Remove mutating webhook that doesn't do anything #4233

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e6a6b49
Remove mutating webhook that doesn't do anything
garvinp-stripe Jul 7, 2023
7434888
Merge branch 'main' into remove-noop-mutating-webhook
garvinp-stripe Jul 8, 2023
380523d
Merge branch 'main' into remove-noop-mutating-webhook
garvinp-stripe Jul 10, 2023
5b26939
Merge branch 'main' into remove-noop-mutating-webhook
jonathan-innis Jul 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions charts/karpenter/templates/webhooks.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,17 +19,6 @@ webhooks:
failurePolicy: Fail
sideEffects: None
rules:
- apiGroups:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In order for this to work properly with the Knative reconciliation mechanism, we would need to update the addition of the defaulting webhook for AWSNodeTemplates on this line: https://github.com/aws/karpenter/blob/main/pkg/webhooks/webhooks.go#L44. We can do this but we are planning to remove the entire batch of webhooks in the near-future.

Is this currently blocking anything or causing issues? I'm wondering if we can wait to remove this until we remove all of the webhooks outright.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok no worries not blocking. We could wait.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's alright with you, I'm going to close this since we won't take this right now. You can track the removal of the webhooks through: kubernetes-sigs/karpenter#103

- karpenter.k8s.aws
apiVersions:
- v1alpha1
operations:
- CREATE
- UPDATE
resources:
- awsnodetemplates
- awsnodetemplates/status
scope: '*'
- apiGroups:
- karpenter.sh
apiVersions:
Expand Down