Fix bug in ec2 api mock #354
Conversation
wasn't resetting the list of fake ec2 instances when Reset was called
JacobGabrielson
requested review from
ellistarn,
bwagner5,
njtran and
prateekgogia
|
Turned out the problem was a little bigger than I thought, please re-review @ellistarn. Thanks! |
pkg/cloudprovider/aws/suite_test.go
Outdated
| @@ -222,6 +222,9 @@ var _ = Describe("Allocation", func() { | |||
| }) | |||
| It("should launch separate instances for pods with different node selectors", func() { | |||
| // Setup | |||
| fakeEC2API.DescribeSubnetsOutput = &ec2.DescribeSubnetsOutput{Subnets: []*ec2.Subnet{ | |||
There was a problem hiding this comment.
Shouldn't there simply be a default subnet you can use in this test? I feel it shouldn't be necessary to specify this for this test.
There was a problem hiding this comment.
Fixed - good catch - turned out to be another bug in fakeEC2API
@bwagner5 I haven't looked at it that closely - I think it's to avoid re-creating the kubernetes environment for every individual test (which I think would be very slow?) - and the webhooks need to refer (indirectly) to the ec2 api. |
Issue #, if available: 273
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.