add user-agent string #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JacobGabrielson
previously approved these changes
Apr 8, 2021
ellistarn
reviewed
Apr 8, 2021
| RELEASE_REPO ?= public.ecr.aws/b6u6q9h4 | ||
| RELEASE_VERSION ?= v0.2.0 | ||
| RELEASE_VERSION ?= $(shell git describe --tags --always --dirty) |
There was a problem hiding this comment.
ellistarn
reviewed
Apr 8, 2021
| RELEASE_MANIFEST = releases/${CLOUD_PROVIDER}/manifest.yaml | ||
|
|
||
| ## Inject the app version into project.Version | ||
| LDFLAGS ?= "-ldflags=-X=github.com/awslabs/karpenter/pkg/utils/project.Version=${RELEASE_VERSION}" |
There was a problem hiding this comment.
How do these get picked up. Don't we need something on line 8?
There was a problem hiding this comment.
No, line 8 already includes ${GOFLAGS} which includes the LDFLAGS since they are apart of the GOFLAGS.
ellistarn
reviewed
Apr 8, 2021
pkg/cloudprovider/aws/factory.go
Outdated
| @@ -51,6 +54,8 @@ type Factory struct { | |||
|
|
|||
| func NewFactory(options cloudprovider.Options) *Factory { | |||
| sess := withRegion(session.Must(session.NewSession(&aws.Config{STSRegionalEndpoint: endpoints.RegionalSTSEndpoint}))) | |||
| // add karpenter user-agent string to AWS session | |||
| sess.Handlers.Build.PushBack(request.MakeAddToUserAgentFreeFormHandler(fmt.Sprintf("karpenter.sh-%s", project.Version))) | |||
There was a problem hiding this comment.
can you encapsulate this into withUserAgent
ellistarn
reviewed
Apr 8, 2021
pkg/utils/project/project.go
Outdated
| var ( | ||
| // Version is the karpenter app version injected during compilation | ||
| // when using the Makefile | ||
| Version = "dev" |
There was a problem hiding this comment.
Will this ever show as dev if we use git tags?
There was a problem hiding this comment.
if someone does go build ./... or something like that without specifying the LDFLAGS (so not using the Makefile)
There was a problem hiding this comment.
Interesting. Can we say unspecified, instead?
JacobGabrielson
previously approved these changes
Apr 8, 2021
JacobGabrielson
approved these changes
Apr 9, 2021
ellistarn
approved these changes
Apr 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.