Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Unit tests] make it easier to create pending test pods #351

Merged
merged 7 commits into from
Apr 8, 2021

Conversation

JacobGabrielson
Copy link
Contributor

Issue #, if available:

Description of changes:

See summary

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

pkg/test/pods/pods.go Outdated Show resolved Hide resolved
bwagner5
bwagner5 previously approved these changes Apr 8, 2021
Copy link
Contributor

@bwagner5 bwagner5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small comment, otherwise lgtm!

pkg/test/pods/pods.go Outdated Show resolved Hide resolved
pkg/test/pods.go Outdated Show resolved Hide resolved
ellistarn
ellistarn previously approved these changes Apr 8, 2021
bwagner5
bwagner5 previously approved these changes Apr 8, 2021
Copy link
Contributor

@bwagner5 bwagner5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@JacobGabrielson JacobGabrielson dismissed stale reviews from bwagner5 and ellistarn via 22660b9 April 8, 2021 19:40
Copy link
Contributor

@bwagner5 bwagner5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 🥳 💯 💯 💯 💯 lgtm

@JacobGabrielson JacobGabrielson merged commit 30ba533 into aws:main Apr 8, 2021
@JacobGabrielson JacobGabrielson deleted the lt3 branch April 8, 2021 19:49
@JacobGabrielson JacobGabrielson linked an issue Apr 20, 2021 that may be closed by this pull request
gfcroft pushed a commit to gfcroft/karpenter-provider-aws that referenced this pull request Nov 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide mechanism to override ec2 launch template for nodes
3 participants