Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: cleaned up a few log lines #2945

Merged
merged 1 commit into from
Dec 1, 2022
Merged

chore: cleaned up a few log lines #2945

merged 1 commit into from
Dec 1, 2022

Conversation

ellistarn
Copy link
Contributor

@ellistarn ellistarn commented Nov 30, 2022 •
edited
Loading

Fixes #

Description

Cleaned up a few log lines and updated to the buddy PR: kubernetes-sigs/karpenter#91
Blocked on: kubernetes-sigs/karpenter#94

How was this change tested?

  • make test

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ellistarn ellistarn requested a review from a team as a code owner November 30, 2022 23:11
@ellistarn ellistarn requested a review from spring1843 November 30, 2022 23:11
@netlify
Copy link

netlify bot commented Nov 30, 2022 •
edited
Loading

✅ Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 4d9165d
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/6388fa6e6cf30d00084b0518

jonathan-innis
jonathan-innis previously approved these changes Nov 30, 2022
View reviewed changes
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@ellistarn ellistarn force-pushed the 2902 branch 9 times, most recently from 41a745f to c43b7a2 Compare December 1, 2022 19:00
@ellistarn ellistarn enabled auto-merge (squash) December 1, 2022 19:03
jonathan-innis
jonathan-innis approved these changes Dec 1, 2022
View reviewed changes
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@ellistarn ellistarn merged commit 93ee09e into aws:main Dec 1, 2022
@ellistarn ellistarn deleted the 2902 branch December 1, 2022 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathan-innis jonathan-innis jonathan-innis approved these changes

@spring1843 spring1843 Awaiting requested review from spring1843 spring1843 is a code owner automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ellistarn @jonathan-innis