-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple updates in hack/quick-install.sh #185
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,15 +4,17 @@ set -eu -o pipefail | |
main() { | ||
local command=${1:-'--apply'} | ||
if [[ $command = "--apply" ]]; then | ||
echo "Installing Karpenter & dependencies.." | ||
apply | ||
echo "Installation complete!" | ||
elif [[ $command = "--delete" ]]; then | ||
echo "Uninstalling Karpenter & dependencies.." | ||
delete | ||
echo "Uninstallation complete!" | ||
else | ||
echo "Error: invalid argument: $command" >&2 | ||
usage | ||
exit 22 # EINVAL | ||
exit 22 # EINVAL | ||
fi | ||
} | ||
|
||
|
@@ -27,11 +29,11 @@ EOF | |
} | ||
|
||
delete() { | ||
helm delete karpenter || true | ||
helm delete cert-manager --namespace cert-manager || true | ||
helm delete kube-prometheus-stack --namespace monitoring || true | ||
helm delete karpenter || true | ||
|
||
kubectl delete namespace cert-manager monitoring || true | ||
kubectl delete namespace cert-manager monitoring || true #here | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can you revert this line? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No problem, will do. |
||
} | ||
|
||
# If this fails you may have an old installation hanging around. | ||
|
@@ -67,8 +69,8 @@ apply() { | |
--set nodeExporter.enabled=false \ | ||
--set prometheus.enabled=false | ||
|
||
helm upgrade --install karpenter charts/karpenter | ||
helm upgrade --install karpenter karpenter/karpenter | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. +1 nice catch |
||
} | ||
|
||
usage | ||
main "$@" | ||
main "$@" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you leave the trailing newline here? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No problem, will do. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice catch! I'm a bit shocked that kube-prometheus-stack doesn't delete child resources via k8s garbage collection.