manually install golicense from the last release #1657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for karpenter-docs-prod canceled.
|
tzneal
force-pushed
the
install-golicense-release
branch
from
87435ea to
b3d5735
Compare
bwagner5
reviewed
Apr 11, 2022
| @@ -15,14 +15,23 @@ tools() { | |||
| go install github.com/golangci/golangci-lint/cmd/[email protected] | |||
| go install github.com/google/[email protected] | |||
| go install github.com/mikefarah/yq/[email protected] | |||
| go install github.com/mitchellh/[email protected] | |||
There was a problem hiding this comment.
looks like golicense install is duplicated on line 13 :D
ellistarn
reviewed
Apr 11, 2022
hack/toolchain.sh
Outdated
| go install github.com/norwoodj/helm-docs/cmd/[email protected] | ||
| go install github.com/onsi/ginkgo/[email protected] | ||
| go install sigs.k8s.io/controller-runtime/tools/[email protected] | ||
| go install sigs.k8s.io/controller-tools/cmd/[email protected] | ||
| go install github.com/sigstore/cosign/cmd/[email protected] | ||
| go install github.com/gohugoio/[email protected]+extended | ||
|
|
||
| # golicense no longer builds with go 1.18+, for now just install the last release binary | ||
| if [[ $(go env GOOS) == "darwin" ]]; then |
There was a problem hiding this comment.
Can we wrap this with a helper like kubebuilder?
There was a problem hiding this comment.
Another option would be to keep an older version of go on the host and just use that for the install command.
There was a problem hiding this comment.
Just created a helper for now, I viewed this as an interim solution to allow us to move to Go 1.18 whenever we want to. Hopefully the main repo will accept a PR or a fork will emerge that has this feature fixed.
tzneal
force-pushed
the
install-golicense-release
branch
from
b3d5735 to
0d59166
Compare
tzneal
force-pushed
the
install-golicense-release
branch
from
0d59166 to
67e9e68
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Issue, if available:
N/A
2. Description of changes:
golicense doesn't build with go 1.18+, so instead of installing golicense from source, install the last release.
3. How was this change tested?
Locally, this PR should test is with VI
4. Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.