Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stale issue closer in dry run mode #1650

Merged
merged 1 commit into from
Apr 8, 2022
Merged

Add stale issue closer in dry run mode #1650

merged 1 commit into from
Apr 8, 2022

Conversation

spring1843
Copy link
Contributor

1. Issue, if available:

2. Description of changes:
This is a different issue closer than the one we used before. The other plugin we used before did not behave correctly with regards to label exemptions. This one should do a better job.

This is gonna run in dry mode so we are gonna see if it would behave properly and if it does we can permanently enable it.

3. How was this change tested?

4. Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: link to issue
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@spring1843 spring1843 requested a review from a team as a code owner April 8, 2022 18:36
@netlify
Copy link

netlify bot commented Apr 8, 2022

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 03bf3a3
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/6250809e9a00610008d6b0c4

Copy link
Contributor

@bwagner5 bwagner5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@spring1843 spring1843 merged commit 7ffe65f into aws:main Apr 8, 2022
@spring1843 spring1843 deleted the rm/add-different-stale branch April 8, 2022 18:55
@suket22 suket22 mentioned this pull request May 23, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants