Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix two broken links and update troubleshooting webhooks #1631

Merged
merged 3 commits into from
Apr 6, 2022

Conversation

bwagner5
Copy link
Contributor

@bwagner5 bwagner5 commented Apr 6, 2022

1. Issue, if available:
N/A

2. Description of changes:

  • Fix two broken links in previous website versions that shows up on the 404 checker when releasing. These sections should have been removed in those version since the dashboards are imported automatically beginning at v0.5.6.
  • Fix troubleshooting webhooks section which is out-dated since the webhook and controller are now in the same pod.
  • Fix inconsistent casing on the Getting Started landing page. All other links have "Started" capitalized except "Getting started with eksctl"

3. How was this change tested?

  • make website

4. Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: link to issue
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@bwagner5 bwagner5 requested a review from a team as a code owner April 6, 2022 16:32
@netlify
Copy link

netlify bot commented Apr 6, 2022

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit 2937791
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/624dc1a4f834f80008736e64
😎 Deploy Preview https://deploy-preview-1631--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@dewjam
Copy link
Contributor

dewjam commented Apr 6, 2022

lgtm

@bwagner5 bwagner5 merged commit 79edd3e into aws:main Apr 6, 2022
@bwagner5 bwagner5 deleted the website-fixes branch April 6, 2022 16:56
@suket22 suket22 mentioned this pull request May 23, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants