Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added several more troubleshooting issues to docs #1618

Merged
merged 6 commits into from
Apr 6, 2022
Merged

Added several more troubleshooting issues to docs #1618

merged 6 commits into from
Apr 6, 2022

Conversation

chrisnegus
Copy link
Member

1. Issue, if available:
Added troubleshooting items related to Issue #933 and several slack threads.

2. Description of changes:
The following troubleshooting entries were added:

  • Reapply credentials with Terraform connection failure (@dewjam, please review)
  • Terraform fails to create instance profile when name is too long (@dewjam, please review)
  • Karpenter Role names exceeding 64-character limit (@spring1843, please review)
  • Node terminates before ready on failed encrypted EBS volume (@bwagner5, please review)

3. Does this change impact docs?

  • Yes, PR includes docs updates

This is currently a work in progress.

@chrisnegus chrisnegus added documentation Improvements or additions to documentation troubleshooting Issues with running Karpenter labels Apr 2, 2022
@chrisnegus chrisnegus self-assigned this Apr 2, 2022
@chrisnegus chrisnegus requested a review from a team as a code owner April 2, 2022 19:41
@netlify
Copy link

netlify bot commented Apr 2, 2022 •
edited
Loading

✅ Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit 9b1baea
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/624e167eb136c700087dc3dc
😎 Deploy Preview https://deploy-preview-1618--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@chrisnegus chrisnegus marked this pull request as draft April 2, 2022 19:46
spring1843
spring1843 previously approved these changes Apr 6, 2022
View reviewed changes
Copy link
Contributor

@spring1843 spring1843 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "Karpenter Role names exceeding 64-character limit" part LGTM.

chrisnegus
chrisnegus commented Apr 6, 2022
View reviewed changes
Copy link
Member Author

@chrisnegus chrisnegus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think all the comments are in. I'm going to remove the draft and I think it's ready to merge.

website/content/en/preview/troubleshooting.md Outdated Show resolved Hide resolved
website/content/en/preview/troubleshooting.md Outdated Show resolved Hide resolved
@chrisnegus chrisnegus changed the title [WIP] Added several more troubleshooting issues to docs Added several more troubleshooting issues to docs Apr 6, 2022
@chrisnegus chrisnegus marked this pull request as ready for review April 6, 2022 22:34
bwagner5
bwagner5 approved these changes Apr 6, 2022
View reviewed changes
Copy link
Contributor

@bwagner5 bwagner5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@chrisnegus chrisnegus merged commit 738794d into aws:main Apr 6, 2022
@suket22 suket22 mentioned this pull request May 23, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njtran njtran njtran left review comments

@dewjam dewjam dewjam left review comments

@bwagner5 bwagner5 bwagner5 approved these changes

@spring1843 spring1843 spring1843 left review comments

Assignees

@chrisnegus chrisnegus

Labels
documentation Improvements or additions to documentation troubleshooting Issues with running Karpenter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chrisnegus @spring1843 @dewjam @bwagner5 @njtran