Decoupled Constraints API object from internal representation #1603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for karpenter-docs-prod canceled.
|
ellistarn
force-pushed
the
provider
branch
4 times, most recently
from
17b953f to
af39618
Compare
tzneal
reviewed
Mar 31, 2022
| aws := &AWS{} | ||
| _, gvk, err := Codec.UniversalDeserializer().Decode(constraints.Provider.Raw, nil, aws) | ||
| p := &Provider{} | ||
| _, gvk, err := Codec.UniversalDeserializer().Decode(provider.Raw, nil, p) |
There was a problem hiding this comment.
I know this wasn't changed, but it looked weird and from my reading of the docs we are safer to use the return value as opposed to assuming it populates p:
// If into is non-nil, it will be used as the target type
// and implementations may choose to use it rather than reallocating an object. However, the object is not
// guaranteed to be populated.
There was a problem hiding this comment.
To derisk, we can we cover this in another PR?
bwagner5
requested changes
Mar 31, 2022
ellistarn
force-pushed
the
provider
branch
2 times, most recently
from
0583d99 to
a7acc52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Issue, if available:
#1350
2. Description of changes:
This is the first change in a series of changes to decouple the v1alpha5 API package from our internal node representation.
3. How was this change tested?
4. Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.