Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile #1587

Merged
merged 2 commits into from
Mar 29, 2022
Merged

Makefile #1587

merged 2 commits into from
Mar 29, 2022

Conversation

dewjam
Copy link
Contributor

@dewjam dewjam commented Mar 29, 2022

1. Issue, if available:
When releasing a new version of Karpenter, it's possible to leave CLOUD_PROVIDER environment variable unset. If CLOUD_PROVIDER is not set, the resultant artifact defaults to the fake/test cloud provider.

If you run make release more than once, the 'preview' website content is copied inside of the 'versioned' website content when it should not be.

2. Description of changes:
This changes requires the CLOUD_PROVIDER environment variable to be set when running make release. Additionally, it makes the website content copy step idempotent.

3. How was this change tested?
Ran make release multiple times with the CLOUD_PROVIDER env set and unset. When unset or set to an empty string, the release fails.

GOFLAGS="-tags= -ldflags=-X=github.com/aws/karpenter/pkg/utils/project.Version=v0.7.3-13-g5495dd3" ./hack/release.sh
CLOUD_PROVIDER environment variable is not set: 'export CLOUD_PROVIDER=aws'
make: *** [release] Error 1

When the CLOUD_PROVIDER env is set and make release is executed multiple times, the 'preview' content is not copied inside of the versioned content folder.

drwxr-xr-x  7 user group 4.0K Mar 29 14:58 .
drwxr-xr-x 20 user group 4.0K Mar 29 14:57 ..
drwxr-xr-x  2 user group 4.0K Mar 29 14:58 AWS
drwxr-xr-x  2 user group 4.0K Mar 29 14:58 concepts
-rw-r--r--  1 user group 4.2K Mar 29 14:58 development-guide.md
-rw-r--r--  1 user group  12K Mar 29 14:58 faq.md
drwxr-xr-x  5 user group 4.0K Mar 29 14:58 getting-started
-rwxr-xr-x  1 user group 1.6K Mar 29 14:58 _index.md
-rw-r--r--  1 user group  7.7K Mar 29 14:58 provisioner.md
drwxr-xr-x  2 user group  4.0K Mar 29 14:58 tasks
-rw-r--r--  1 user group  4.8K Mar 29 14:58 troubleshooting.md
drwxr-xr-x  2 user group  4.0K Mar 29 14:58 upgrade-guide

4. Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: link to issue
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@netlify
Copy link

netlify bot commented Mar 29, 2022

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 5495dd3
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/62433075445fed00084dbb6f

Copy link
Contributor

@bwagner5 bwagner5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bwagner5 bwagner5 merged commit ce91c90 into aws:main Mar 29, 2022
@spring1843 spring1843 self-requested a review March 29, 2022 17:25
@spring1843 spring1843 mentioned this pull request Mar 29, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants