Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Issue, if available:
When releasing a new version of Karpenter, it's possible to leave CLOUD_PROVIDER environment variable unset. If CLOUD_PROVIDER is not set, the resultant artifact defaults to the fake/test cloud provider.
If you run
make release
more than once, the 'preview' website content is copied inside of the 'versioned' website content when it should not be.2. Description of changes:
This changes requires the CLOUD_PROVIDER environment variable to be set when running
make release
. Additionally, it makes the website content copy step idempotent.3. How was this change tested?
Ran
make release
multiple times with the CLOUD_PROVIDER env set and unset. When unset or set to an empty string, the release fails.When the CLOUD_PROVIDER env is set and
make release
is executed multiple times, the 'preview' content is not copied inside of the versioned content folder.4. Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.