Moved node generation logic to be owned by constraints #1566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for karpenter-docs-prod canceled.
|
tzneal
reviewed
Mar 23, 2022
| node.Labels = functional.UnionStringMaps(node.Labels, constraints.GenerateLabels()) | ||
| node.Spec.Taints = append(node.Spec.Taints, constraints.Taints...) | ||
| return p.bind(ctx, node, <-pods) | ||
| n := constraints.ToNode() |
There was a problem hiding this comment.
Did we drop the resources that the cloud provider added to the node here? (mergo wouldn't have, sorry :( ). If we did and no test caught it, we should definitely add a test for that.
tzneal
approved these changes
Mar 23, 2022
tzneal
approved these changes
Mar 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Issue, if available:
2. Description of changes:
Another touchup that moves logic out of the provisioner.
3. How was this change tested?
4. Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.