add more scheduling unit tests #1565
Conversation
✅ Deploy Preview for karpenter-docs-prod canceled.
|
tzneal
force-pushed
the
add-more-scheduling-tests
branch
from
dc522b0 to
b823dce
Compare
- ensures that all instance types passed to the cloud provider meet the required constraints - verify prov/pod constraints on OS - verify prov/pod constraints on zone/capacity type - verify mixed prov/pod constraints
Yeah, that would be great! I don't think ginkgo supports table driven tests, but we could make a test helper that lets you pass in the list of instance types. One could be this unique set and the other are a snapshot of what real instance types were. That would be good to hook into the AWS CP EC2 Instance Type -> cloudprovider.InstanceType translation as well to get more testing on that. |
tzneal
force-pushed
the
add-more-scheduling-tests
branch
from
b823dce to
f33a1b7
Compare
| } | ||
| } | ||
| } | ||
| }) |
There was a problem hiding this comment.
If I understand correctly, the above cases can all find compatible instance type for the give pod. Can we add some cases with multiple pods that will create incompatibility and we should see them been put on separated nodes?
There was a problem hiding this comment.
This set of tests was geared at two recent issues that caused point releases where we were passing a set of instance types to the cloudprovider where some, but not all of the instance types matched the constraints. We have some individual tests for that behavior:
- "should launch pods with resources that aren't on any single instance type on different instances"
- "should schedule incompatible pods to the different node"
1. Issue, if available:
N/A
2. Description of changes:
Adds additional unit tests to scheduling:
the required constraints
3. How was this change tested?
Unit test, no functional changes were made.
4. Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.