Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong YAML key #1560

Merged
merged 1 commit into from
Mar 23, 2022
Merged

Fix wrong YAML key #1560

merged 1 commit into from
Mar 23, 2022

Conversation

sylr
Copy link
Contributor

@sylr sylr commented Mar 23, 2022

1. Issue, if available:

2. Description of changes:

3. How was this change tested?

4. Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: link to issue
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@netlify
Copy link

netlify bot commented Mar 23, 2022 •
edited
Loading

✅ Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit b6a87a1
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/623b01ebaf927000094658a4

tzneal
tzneal approved these changes Mar 23, 2022
View reviewed changes
Copy link
Contributor

@tzneal tzneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified that this allows the additionalAnnotations in values.yaml to be applied to the logging config map correctly.

@tzneal tzneal merged commit 81d523b into aws:main Mar 23, 2022
@sylr sylr deleted the patch-1 branch December 14, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzneal tzneal tzneal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sylr @tzneal