our price ordering no longer provides the guarantee that made this work #1555
Conversation
✅ Deploy Preview for karpenter-docs-prod canceled.
|
| bestPackedPods = result.packed | ||
| remainingPods = result.unpacked | ||
| break | ||
| // reached the max that we care about | ||
| if len(bestInstances) == MaxInstanceTypes { |
There was a problem hiding this comment.
since we filter out instance types in the CP now, it might make sense to just move the MaxInstanceTypes to the CP or increase this value. It might make the bin-packer do a lot more work though...
There was a problem hiding this comment.
Alternatively, build this on a branch and whole hog move towards a unified scheduler/binpacker.
There was a problem hiding this comment.
That's the next step, but right now it sometimes creates instance types that are too small. Was hoping to get this in as a patch before any release.
There was a problem hiding this comment.
since we filter out instance types in the CP now, it might make sense to just move the MaxInstanceTypes to the CP or increase this value. It might make the bin-packer do a lot more work though...
I think it will with a converged scheduler/bin packer. I think scheduling costs will dominate any bin packing cost anyway.
tzneal
force-pushed
the
fix-packing-bug
branch
2 times, most recently
from
53940b7 to
6453d73
Compare
1. Issue, if available:
N/A
2. Description of changes:
Remove packing optimization that doesn't work with arbitrary price sorting.
3. How was this change tested?
Unit tests & by hand on EKS
4. Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.