fix issue regarding not pre-filtering instance types by provider constraints #1543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Deploy Preview for karpenter-docs-prod canceled. 🔨 Explore the source changes: ea8084b 🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/6234fa4b198e730008ad7114 |
tzneal
force-pushed
the
fix-prefilter-of-instance-types
branch
from
e05e571 to
4da1f70
Compare
| @@ -109,6 +109,8 @@ func (c *CloudProvider) GetInstanceTypes(_ context.Context, _ *v1alpha5.Provider | |||
| NewInstanceType(InstanceTypeOptions{ | |||
| Name: "arm-instance-type", | |||
| Architecture: "arm64", | |||
| CPU: resource.MustParse("16"), | |||
There was a problem hiding this comment.
I am curious why do we need to specify the CPU and memory here?
There was a problem hiding this comment.
I can only verify what it gets scheduled to, so I bumped the cpu/memory up and set a corresponding request in the pod to force it to either fit this instance or not be scheduled. Now with the filtering, it ends up not scheduled.
tzneal
force-pushed
the
fix-prefilter-of-instance-types
branch
from
4da1f70 to
ea8084b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Issue, if available:
Fixes #1540
2. Description of changes:
Pre-filter the available instance types by the provider constraints
3. How was this change tested?
4. Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.