Get rid of the equal char when calling bootstrap.sh #1520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…parse it and assume its empty. Which will result in it trying to find the API server automatically which works for EKS cluster but does not for others
|
✔️ Deploy Preview for karpenter-docs-prod canceled. 🔨 Explore the source changes: a84e207 🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/6230f75242136f00084d353f |
spring1843
changed the title
ellistarn
previously approved these changes
Mar 15, 2022
ellistarn
previously approved these changes
Mar 15, 2022
bwagner5
requested changes
Mar 15, 2022
ellistarn
approved these changes
Mar 15, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Issue, if available:
2. Description of changes:
Get rid of the equal sign because the bootstrap.sh will not properly parse it and assume it is empty. Which will result in it trying to find the API server automatically which works for EKS cluster but does not for others.
The extra
=s were added in #1420This is a problem introduced in
3. How was this change tested?
4. Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.