Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update docs regarding the TTL times #1461

Merged
merged 1 commit into from
Mar 3, 2022

Conversation

tzneal
Copy link
Contributor

@tzneal tzneal commented Mar 3, 2022

1. Issue, if available:

N/A

2. Description of changes:

  • replace 'nil' with 'omitted' for clarification
  • add tests to ensure omitted values are considered valid

3. How was this change tested?
Unit tests

4. Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: link to issue
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@tzneal tzneal requested a review from geoffcline March 3, 2022 16:05
@netlify
Copy link

netlify bot commented Mar 3, 2022

✔️ Deploy Preview for karpenter-docs-prod canceled.

🔨 Explore the source changes: 4185049

🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/622120c74cb386000701e7d1

ellistarn
ellistarn previously approved these changes Mar 3, 2022
Copy link
Contributor

@ellistarn ellistarn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One optional comment

- replace 'nil' with 'omitted' for clarification
- add tests to ensure omitted values are considered valid
@ellistarn ellistarn merged commit 1c0f0dc into aws:main Mar 3, 2022
@tzneal tzneal deleted the expire-docs-clarification branch March 4, 2022 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants