Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update tags doc #1458

Merged
merged 1 commit into from
Mar 4, 2022
Merged

update tags doc #1458

merged 1 commit into from
Mar 4, 2022

Conversation

tzneal
Copy link
Contributor

@tzneal tzneal commented Mar 3, 2022

1. Issue, if available:

2. Description of changes:

  • Document that tags are applied to created volumes as well
  • Reword to indicate that we both merge & override

3. How was this change tested?
Unit test & doc changes only.

4. Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: link to issue
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@netlify
Copy link

netlify bot commented Mar 3, 2022

✔️ Deploy Preview for karpenter-docs-prod ready!

🔨 Explore the source changes: 7219f42

🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/6221227af6bb9a0007e881fc

😎 Browse the preview: https://deploy-preview-1458--karpenter-docs-prod.netlify.app

@tzneal tzneal requested a review from geoffcline March 3, 2022 02:14
- Document that tags are applied to created volumes as well
- Reword to indicate that we both merge & override
@tzneal tzneal force-pushed the update-tags-doc branch from 995987f to 7219f42 Compare March 3, 2022 20:18
@tzneal tzneal merged commit 0349e2d into aws:main Mar 4, 2022
@tzneal tzneal deleted the update-tags-doc branch March 4, 2022 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants