Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch markdownify to safeHTML #1453

Merged
merged 1 commit into from
Mar 2, 2022
Merged

switch markdownify to safeHTML #1453

merged 1 commit into from
Mar 2, 2022

Conversation

tzneal
Copy link
Contributor

@tzneal tzneal commented Mar 2, 2022

1. Issue, if available:

2. Description of changes:

markdownify turns '--' into an emdash which makes the included scripts
invalid for copying/pasting into a shell.

3. How was this change tested?

Netlify preview

4. Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: link to issue
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

markdownify turns '--' into an emdash which makes the included scripts
invalid for copying/pasting into a shell.
@netlify
Copy link

netlify bot commented Mar 2, 2022

✔️ Deploy Preview for karpenter-docs-prod ready!

🔨 Explore the source changes: 94a4caa

🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/621f820681e1ae000799f9ea

😎 Browse the preview: https://deploy-preview-1453--karpenter-docs-prod.netlify.app

Copy link
Contributor

@bwagner5 bwagner5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Nice catch!

@bwagner5 bwagner5 merged commit e1e585c into aws:main Mar 2, 2022
@tzneal tzneal deleted the fix-doc-emdash branch March 3, 2022 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants