Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable debug logging by default #1447

Merged
merged 2 commits into from
Mar 1, 2022
Merged

Enable debug logging by default #1447

merged 2 commits into from
Mar 1, 2022

Conversation

ellistarn
Copy link
Contributor

1. Issue, if available:

2. Description of changes:
Users have been facing issues that would have been resolved by viewing debug logging. Given how we treat debug logging today, it's useful to leave on as default, and users can filter (or turn down) as necessary.

3. How was this change tested?

4. Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: link to issue
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@netlify
Copy link

netlify bot commented Mar 1, 2022

✔️ Deploy Preview for karpenter-docs-prod ready!

🔨 Explore the source changes: 1dc12ea

🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/621eaa9859cdfb0007d05725

😎 Browse the preview: https://deploy-preview-1447--karpenter-docs-prod.netlify.app

Copy link
Contributor

@felix-zhe-huang felix-zhe-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ellistarn ellistarn merged commit ed4a22b into aws:main Mar 1, 2022
@ellistarn ellistarn deleted the log branch March 4, 2022 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants