Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deeper podAffinity and anti-affinity checks #1442

Merged
merged 2 commits into from
Mar 2, 2022
Merged

deeper podAffinity and anti-affinity checks #1442

merged 2 commits into from
Mar 2, 2022

Conversation

bwagner5
Copy link
Contributor

@bwagner5 bwagner5 commented Mar 1, 2022

1. Issue, if available:
N/A

2. Description of changes:

  • This adds a deeper check for podAffinity and podAntiAffinity. Before we were only checking if it was nil. There are some helm charts will will expose the podAffinity and anti-affinity in the values.yaml and will therefore populate them as empty instead of not specified. Karpenter would ignore these pods unnecessarily.

3. How was this change tested?

  • Tested a pod w/ anti-affinity -> Karpenter ignores pod
  • Tested a pod w/ empty anti-affinity -> Karpenter schedules
  • Tested a pod w/ no anti-affinity -> Karpenter schedules

4. Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: link to issue
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@netlify
Copy link

netlify bot commented Mar 1, 2022 •
edited
Loading

✔️ Deploy Preview for karpenter-docs-prod canceled.

🔨 Explore the source changes: b4cc479

🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/621eb6c264f0030008c2b95f

@bwagner5 bwagner5 requested a review from ellistarn March 1, 2022 18:31
@bwagner5 bwagner5 requested a review from ellistarn March 1, 2022 19:19
ellistarn
ellistarn reviewed Mar 1, 2022
View reviewed changes
Copy link
Contributor

@ellistarn ellistarn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind writing a test for this?

@bwagner5 bwagner5 changed the title deeper podAffinity and anit-affinity checks deeper podAffinity and anti-affinity checks Mar 2, 2022
@bwagner5 bwagner5 requested a review from ellistarn March 2, 2022 00:34
@ellistarn ellistarn merged commit 8a3b230 into aws:main Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ellistarn ellistarn ellistarn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bwagner5 @ellistarn