-
Notifications
You must be signed in to change notification settings - Fork 983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update AWS Provisioner docs w/ proper tag examples #1402
Conversation
✔️ Deploy Preview for karpenter-docs-prod ready! 🔨 Explore the source changes: ecf2b0e 🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/6215594575c7d30007bcc5a2 😎 Browse the preview: https://deploy-preview-1402--karpenter-docs-prod.netlify.app |
@@ -0,0 +1 @@ | |||
/{{ replace (chomp (delimit (first 2 (split .Page.RelPermalink "/")) "" "")) "preview" .Page.Site.Params.github_branch }}/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we leave the slashes outside, e.g. /{{< githubRelRef > }}/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can, the reason I have it like this is to match the {{< relref >}}
that we use for the versioned links for docs pages which includes the slashes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh gotcha
1. Issue, if available:
#1310
2. Description of changes:
karpenter.sh/discovery
tags in examplesName
example (it was using the id rather than name)3. How was this change tested?
4. Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.