Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add empty test suite to get rid of the Ginkgo warning #1396

Merged
merged 2 commits into from
Feb 22, 2022
Merged

Add empty test suite to get rid of the Ginkgo warning #1396

merged 2 commits into from
Feb 22, 2022

Conversation

spring1843
Copy link
Contributor

@spring1843 spring1843 commented Feb 22, 2022

1. Issue, if available:
#1338 (comment)

There's a warning in make test

make test
ginkgo -r
[1645488461] Validation - 52/52 specs •••••••••••••••••••••••••••••••••••••••••••••••••••• SUCCESS! 1.632009ms PASS
[1645488461] CloudProvider/AWS - 41/41 specs ••••••••••••••••••••••••••••••••••••••••• SUCCESS! 11.314522285s PASS
[1645488461] Node - 18/18 specs •••••••••••••••••• SUCCESS! 10.520671872s PASS
[1645488461] Volume - 3/3 specs ••• SUCCESS! 6.879056936s PASS
[1645488461] Controllers/Provisioning - 12/12 specs •••••••••••• SUCCESS! 9.398906116s PASS
PASS
testing: warning: no tests to run
Found no test suites, did you forget to run "ginkgo bootstrap"?[1645488461] Controllers/Scheduling - 44/44 specs •••••••S•••••••••••••••••••••••••••••••••••• SUCCESS! 12.433359071s PASS
[1645488461] Controllers/Selection - 12/12 specs •••••••••••• SUCCESS! 9.188944899s PASS
[1645488461] Termination - 9/9 specs ••••••••• SUCCESS! 11.817598447s PASS
[1645488461] Functional Suite - 6/6 specs •••••• SUCCESS! 253.52µs PASS
[1645488461] Sets Suite - 11/11 specs ••••••••••• SUCCESS! 408.054µs PASS

Ginkgo ran 11 suites in 1m30.812771144s
Test Suite Passed

2. Description of changes:
Gets rid of the warning. It seems like Ginggo needs to have a test suite defined everywhere there are *_test.go files.
With this change the output will have

[1645488642] Binpacking Suite - 0/0 specs  SUCCESS! 144.803µs PASS

3. How was this change tested?

4. Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: link to issue
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@netlify
Copy link

netlify bot commented Feb 22, 2022

✔️ Deploy Preview for karpenter-docs-prod canceled.

🔨 Explore the source changes: 05def0a

🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/62142d44f855e90008b577f7

ellistarn
ellistarn previously approved these changes Feb 22, 2022
@spring1843 spring1843 merged commit 70cc8c6 into aws:main Feb 22, 2022
@spring1843 spring1843 deleted the rm/fix-ginkgo-warning branch February 22, 2022 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants