Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: amiFamily values #1364

Merged
merged 1 commit into from
Feb 17, 2022
Merged

fix: amiFamily values #1364

merged 1 commit into from
Feb 17, 2022

Conversation

Anorlondo448
Copy link
Contributor

@Anorlondo448 Anorlondo448 commented Feb 17, 2022

1. Issue, if available:

2. Description of changes:
The value of amiFamily in a Document is incorrect.

[error]

$ kubectl apply -f provisioner.yaml
Error from server (BadRequest): error when applying patch:
{"metadata":{"annotations":{"kubectl.kubernetes.io/last-applied-configuration":"{\"apiVersion\":\"karpenter.sh/v1alpha5\",\"kind\":\"Provisioner\",\"metadata\":{\"annotations\":{},\"name\":\"default\"},\"spec\":{\"limits\":{\"resources\":{\"cpu\":1000}},\"provider\":{\"amiFamily\":\"bottlerocket\",\"instanceProfile\":\"KarpenterNodeInstanceProfile-xxxxxxxxxx\",\"securityGroupSelector\":{\"karpenter.sh/discovery\":\"xxxxxxxxxx\"},\"subnetSelector\":{\"karpenter.sh/discovery\":\"xxxxxxxxxx\"}},\"requirements\":[{\"key\":\"karpenter.sh/capacity-type\",\"operator\":\"In\",\"values\":[\"on-demand\"]},{\"key\":\"node.kubernetes.io/instance-type\",\"operator\":\"In\",\"values\":[\"m5.large\"]}],\"ttlSecondsAfterEmpty\":30}}\n"}},"spec":{"limits":{"resources":{"cpu":1000}},"provider":{"amiFamily":"bottlerocket"},"requirements":[{"key":"karpenter.sh/capacity-type","operator":"In","values":["on-demand"]},{"key":"node.kubernetes.io/instance-type","operator":"In","values":["m5.large"]}]}}
to:
Resource: "karpenter.sh/v1alpha5, Resource=provisioners", GroupVersionKind: "karpenter.sh/v1alpha5, Kind=Provisioner"
Name: "default", Namespace: ""
for: "provisioner.yaml": admission webhook "validation.webhook.provisioners.karpenter.sh" denied the request: validation failed: invalid value: bottlerocket not in Bottlerocket, AL2, Ubuntu: spec.provider.amiFamily

[values]
https://github.com/aws/karpenter/blob/0518fb3440467d59ca836d57fa674bf06ba3c0be/pkg/cloudprovider/aws/apis/v1alpha1/register.go#L35-L37

[docs v0.6.1]
https://github.com/aws/karpenter/blob/a301ce8be13f57d985797f1535e7495f9dbf2964/website/content/en/v0.6.2/AWS/provisioning.md?plain=1#L157

https://github.com/aws/karpenter/blob/a301ce8be13f57d985797f1535e7495f9dbf2964/website/content/en/v0.6.2/AWS/provisioning.md?plain=1#L163-L165

[docs v0.6.2]
https://github.com/aws/karpenter/blob/a301ce8be13f57d985797f1535e7495f9dbf2964/website/content/en/v0.6.3/AWS/provisioning.md?plain=1#L157

https://github.com/aws/karpenter/blob/a301ce8be13f57d985797f1535e7495f9dbf2964/website/content/en/v0.6.3/AWS/provisioning.md?plain=1#L163-L165

3. How was this change tested?

4. Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: link to issue
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@netlify
Copy link

netlify bot commented Feb 17, 2022

✔️ Deploy Preview for karpenter-docs-prod ready!

🔨 Explore the source changes: 1e7ed12

🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/620e4fe8400bac000738ea58

😎 Browse the preview: https://deploy-preview-1364--karpenter-docs-prod.netlify.app

@bwagner5
Copy link
Contributor

Thank you! Can you update the preview docs as well?

@Anorlondo448
Copy link
Contributor Author

OK.
I also added a preview.

Copy link
Contributor

@bwagner5 bwagner5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!! Thanks!

@bwagner5 bwagner5 merged commit 0bf3b55 into aws:main Feb 17, 2022
@Anorlondo448 Anorlondo448 deleted the fix_amifamily branch February 17, 2022 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants