Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few getting started doc improvements #1349

Merged
merged 3 commits into from
Feb 16, 2022
Merged

A few getting started doc improvements #1349

merged 3 commits into from
Feb 16, 2022

Conversation

spring1843
Copy link
Contributor

@spring1843 spring1843 commented Feb 15, 2022

1. Issue, if available:

2. Description of changes:
Few documentation improvements in the getting started guide.

  1. Clarify what is meant by configuring the local aws cli tool
  2. Add export to the environment variable that misses it
  3. Add command to allow kubectl authenticate against the created EKS cluster

3. How was this change tested?

4. Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: link to issue
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@netlify
Copy link

netlify bot commented Feb 15, 2022

✔️ Deploy Preview for karpenter-docs-prod ready!

🔨 Explore the source changes: 310072e

🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/620c2d7deb81a20008a9d05c

😎 Browse the preview: https://deploy-preview-1349--karpenter-docs-prod.netlify.app

@spring1843 spring1843 changed the title Rm/start doc improvements A few getting started doc improvements Feb 15, 2022
@spring1843 spring1843 merged commit 90e4c2d into aws:main Feb 16, 2022
@spring1843 spring1843 deleted the rm/start-doc-improvements branch February 16, 2022 00:25
@@ -78,6 +78,11 @@ eksctl create cluster -f cluster.yaml
export CLUSTER_ENDPOINT="$(aws eks describe-cluster --name ${CLUSTER_NAME} --query "cluster.endpoint" --output text)"
```

You can add the details of the newly created EKS cluster to your local kubectl as a new context by running:
```bash
aws eks update-kubeconfig --region ${AWS_DEFAULT_REGION} --name ${CLUSTER_NAME}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@spring1843 eksctl does this for you - are you sure you needed this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants