Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include the update instructions #1341

Merged
merged 1 commit into from
Feb 15, 2022
Merged

Conversation

felix-zhe-huang
Copy link
Contributor

1. Issue, if available:
Update the FAQ to include update instructions for v0.6.2

2. Description of changes:

3. How was this change tested?

4. Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: link to issue
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@netlify
Copy link

netlify bot commented Feb 14, 2022

✔️ Deploy Preview for karpenter-docs-prod ready!

🔨 Explore the source changes: 50efa27

🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/620ae7a4e2c7370007ef210d

😎 Browse the preview: https://deploy-preview-1341--karpenter-docs-prod.netlify.app

@felix-zhe-huang felix-zhe-huang changed the title Include the update instructions Include the update instructions [WIP] Feb 14, 2022
@felix-zhe-huang felix-zhe-huang changed the title Include the update instructions [WIP] [WIP] Include the update instructions Feb 14, 2022
@felix-zhe-huang felix-zhe-huang force-pushed the update_faq branch 4 times, most recently from 5e80975 to 5695b2c Compare February 14, 2022 22:54
@felix-zhe-huang felix-zhe-huang changed the title [WIP] Include the update instructions Include the update instructions Feb 14, 2022
@ellistarn ellistarn merged commit 3d0d368 into aws:main Feb 15, 2022
--set clusterName=${CLUSTER_NAME} \
--set clusterEndpoint=${CLUSTER_ENDPOINT} \
--set serviceAccount.annotations.eks\.amazonaws\.com/role-arn=${KARPENTER_IAM_ROLE_ARN}
--set aws.defaultInstanceProfile=KarpenterNodeInstanceProfile-${CLUSTER_NAME} \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the instance profile name required like this for auto discovery KarpenterNodeInstanceProfile-${CLUSTER_NAME}? or can users provide any name for the profile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants