Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix test typo (Context/It swapped) #1340

Merged
merged 1 commit into from
Feb 14, 2022
Merged

Conversation

tzneal
Copy link
Contributor

@tzneal tzneal commented Feb 14, 2022

1. Issue, if available:

2. Description of changes:

Fixing ginkgo line swap, container nodes can't be within a subject node (https://onsi.github.io/ginkgo/#organizing-specs-with-container-nodes)

3. How was this change tested?

Unit tests

4. Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: link to issue
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@netlify
Copy link

netlify bot commented Feb 14, 2022

✔️ Deploy Preview for karpenter-docs-prod canceled.

🔨 Explore the source changes: df1b174

🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/620aa1810b7ef400079e709f

@ellistarn ellistarn merged commit b396ad6 into aws:main Feb 14, 2022
@tzneal tzneal deleted the fix-test-typo branch February 15, 2022 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants