Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix overhead calculation to correctly apply kube-reserved cpu #1317

Merged
merged 1 commit into from
Feb 10, 2022

Conversation

bwagner5
Copy link
Contributor

@bwagner5 bwagner5 commented Feb 10, 2022

1. Issue, if available:
N/A

2. Description of changes:

  • The kube-reserved overhead calculation was not being applied correctly on the incremental core percentages.

3. How was this change tested?

  • Printed the overhead calc when investigating the Karpenter cannot fit workload on instance type where it should fit #1306 (this change does not fix that issue) and found that the overhead didn't include the incremental core calc. It only used the initial 100m cpu overhead.
  • After this change, I printed the overhead for r5.12xl and it correctly showed cpu 290m of overhead

4. Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: link to issue
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@netlify
Copy link

netlify bot commented Feb 10, 2022

✔️ Deploy Preview for karpenter-docs-prod canceled.

🔨 Explore the source changes: 20c0980

🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/62056756ca3c2a00087c62fa

@bwagner5 bwagner5 merged commit 9df15a2 into aws:main Feb 10, 2022
@bwagner5 bwagner5 deleted the fix-overhead branch February 10, 2022 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants