Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added annotations and debug level to the helm chart #1274

Closed
wants to merge 1 commit into from

Conversation

alekc
Copy link
Contributor

@alekc alekc commented Feb 4, 2022

1. Issue, if available:
Closes #1263

2. Description of changes:
Added annotations to the controller and webhook, added support for variation of global logging level from helm

3. How was this change tested?
Generated helm templates

4. Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: link to issue
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@netlify
Copy link

netlify bot commented Feb 4, 2022

✔️ Deploy Preview for karpenter-docs-prod canceled.

🔨 Explore the source changes: dd14f9f

🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/61fcf92d1b5c5000079bf556

@stevehipwell
Copy link
Contributor

@alekc the Helm chart refactor PR (#1145) has added annotations using the idiomatic podAnnotations key (it's also added podLabels), hopefully this chart refactor will be released soon. If you need annotations added before then it might be best to use the the podAnnotations key? I haven't added additionalAnnotations to match the additionalLabels value but I could?

@alekc
Copy link
Contributor Author

alekc commented Feb 4, 2022

@stevehipwell missed your PR. I am ok with closing this one and waiting for yours, but we should still add a specific annotations for both controllers and webhooks (not on the pod level, but the root). Several operators relies on those (i.e. https://github.com/stakater/Reloader) and I don't think there is a reason not to give this flexibility.

@stevehipwell
Copy link
Contributor

@alekc the pods have been merged but I'll add the top level additionalAnnotations and log level.

@alekc
Copy link
Contributor Author

alekc commented Feb 4, 2022

cool. Closing this one then

@alekc alekc closed this Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for custom resources annotations on helm chart
2 participants