support region wellknown label #1228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for karpenter-docs-prod canceled. 🔨 Explore the source changes: 9cdf9ee 🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/61f478413673d30007dacf1e |
suket22
reviewed
Jan 27, 2022
|
Can you try this with the in-tree EBS volume controller to make sure that this isn't the only blocker? |
ellistarn
reviewed
Jan 27, 2022
Yeah, I tested with the in-tree and reproduced with the current main HEAD. I deployed this branch and a node gets provisioned successfully and the pod goes to Running. |
ellistarn
reviewed
Jan 27, 2022
ellistarn
reviewed
Jan 27, 2022
|
Super simple now! It just ignores it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Issue, if available:
#1109
#1218
2. Description of changes:
Implement label ignoring w/ region as the first ignored label
3. How was this change tested?
4. Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.