Added preview docs #1152
Merged
Added preview docs #1152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for karpenter-docs-prod ready! 🔨 Explore the source changes: 1a1a392 🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/61e71222185e5e000788cdb5 😎 Browse the preview: https://deploy-preview-1152--karpenter-docs-prod.netlify.app |
ellistarn
force-pushed
the
preview
branch
5 times, most recently
from
daddf0a to
3b4a442
Compare
|
let's /hold this until we discuss removing "getting started" and "docs" from the top nav bar |
ellistarn
force-pushed
the
preview
branch
5 times, most recently
from
84bf3bb to
85a4187
Compare
njtran
approved these changes
Jan 18, 2022
There was a problem hiding this comment.
Generally looks good to me. I'll leave the html review to @geoffcline. I've seen multiple PRs where we are renaming multiple folders. This would be scope creep of the PR, but it would be great to have a bot to check references if possible to make reviews like this easier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Issue, if available:
2. Description of changes:
3. How was this change tested?
4. Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.