Rework deprovisioning docs to add do-not-evict #1147
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for karpenter-docs-prod ready! 🔨 Explore the source changes: a1d6b8d 🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/61e7193502a10a0007260241 😎 Browse the preview: https://deploy-preview-1147--karpenter-docs-prod.netlify.app |
Closed
geoffcline
previously approved these changes
Jan 14, 2022
|
10/10 excellent. I added some optional comments. Do we want to change the filename to "deprovision.md"? I remember Ellis wasn't a fan of "deprov" |
ellistarn
reviewed
Jan 14, 2022
| @@ -1,36 +1,84 @@ | |||
| --- | |||
| title: "Deprovisioning nodes" | |||
There was a problem hiding this comment.
I think you might need a rebase.
There was a problem hiding this comment.
Yeah. I know there have been some changes to this file. I'll do that.
njtran
reviewed
Jan 14, 2022
ellistarn
reviewed
Jan 18, 2022
ellistarn
reviewed
Jan 18, 2022
ellistarn
reviewed
Jan 18, 2022
ellistarn
reviewed
Jan 18, 2022
chrisnegus
commented
Jan 18, 2022
geoffcline
approved these changes
Jan 19, 2022
|
We added this content to the new preview folder instead of the old location. We can close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Issue, if available:
#935
2. Description of changes:
While adding a description of
do-not-evictpods when deprovisioning nodes, I reworked the rest of the Deprovisioning doc.3. Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.