Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update desc of selecting security groups by tag #1121

Merged
merged 1 commit into from
Jan 11, 2022

Conversation

geoffcline
Copy link
Contributor

1. Issue, if available:
#1118

2. Description of changes:
add short note clarifying that a security group is only selected when all criteria match.

3. How was this change tested?
n/a

4. Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: link to issue
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@geoffcline geoffcline added the documentation Improvements or additions to documentation label Jan 11, 2022
@geoffcline geoffcline self-assigned this Jan 11, 2022
@netlify
Copy link

netlify bot commented Jan 11, 2022

✔️ Deploy Preview for karpenter-docs-prod ready!

🔨 Explore the source changes: 7ed2f52

🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/61dd2112c2b0d60007ab3c65

😎 Browse the preview: https://deploy-preview-1121--karpenter-docs-prod.netlify.app

@geoffcline geoffcline linked an issue Jan 11, 2022 that may be closed by this pull request
Copy link
Contributor

@bwagner5 bwagner5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bwagner5 bwagner5 merged commit 7b39064 into main Jan 11, 2022
@bwagner5 bwagner5 deleted the gdc-patch-multiple-selectors branch January 11, 2022 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

multiple securityGroupSelectors
2 participants