fix topologySpread nil label selector bug #1095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for karpenter-docs-prod canceled. 🔨 Explore the source changes: 37fe0a8 🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/61d77d31f727b8000804238a |
bwagner5
force-pushed
the
fix-nil-topology-label-selector
branch
from
1b7a5d0 to
d99bf75
Compare
ellistarn
reviewed
Jan 6, 2022
ellistarn
reviewed
Jan 6, 2022
ellistarn
reviewed
Jan 6, 2022
| MaxSkew: 1, | ||
| }} | ||
| ExpectProvisioned(ctx, env.Client, selectionController, provisioners, provisioner, | ||
| test.UnschedulablePod(test.PodOptions{ObjectMeta: metav1.ObjectMeta{Labels: labels}}), |
There was a problem hiding this comment.
Can we specify pods with different labels just to be safe?
Co-authored-by: Ellis Tarn <[email protected]>
ellistarn
approved these changes
Jan 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Issue, if available:
#1021
2. Description of changes:
Fixes #1021 where if the labelSelector was not provided for a topologySpread, then Karpenter would crash. This fix makes a nil labelSelector select everything per labelSelector docs
3. How was this change tested?
Wrote a unit-test to reproduce the issue, after the fix was implemented, the unit test now passes.
4. Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.