Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump indents for webhook envVars to 12 #1078

Merged
merged 2 commits into from
Jan 4, 2022

Conversation

tokiwong
Copy link
Contributor

@tokiwong tokiwong commented Jan 4, 2022

1. Issue, if available:
Attempting to override KUBERNETES_MIN_VERSION per this error log:

2022-01-03T22:23:16.180Z FATAL webhook Version check failed {"commit": "5047f3c", "error": "kubernetes version "1.19.13-eks-8df270" is not compatible, need at least "1.20.0-0" (this can be overridden with the env var "KUBERNETES_MIN_VERSION")"}

helm template render shows that custom envVars placed in values.yaml have incorrect indentation.

Example:

          env:
            - name: CLUSTER_NAME
              value: 
            - name: CLUSTER_ENDPOINT
              value: 
            - name: SYSTEM_NAMESPACE
              valueFrom:
                fieldRef:
                  fieldPath: metadata.namespace
          - name: KUBERNETES_MIN_VERSION 
             value: 1.19.0-0 

2. Description of changes:
Bumping indentation for envVars from 10 to 12. This keeps the render consistent with indentation found in the controller charts

Example:

          env:
            - name: CLUSTER_NAME
              value: 
            - name: CLUSTER_ENDPOINT
              value: 
            - name: SYSTEM_NAMESPACE
              valueFrom:
                fieldRef:
                  fieldPath: metadata.namespace
            - name: KUBERNETES_MIN_VERSION
               value: 1.19.0-0

3. Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: link to issue
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@netlify
Copy link

netlify bot commented Jan 4, 2022

✔️ Deploy Preview for karpenter-docs-prod canceled.

🔨 Explore the source changes: fdc5050

🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/61d4685694b04800079c0830

@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2022

@check-spelling-bot Report

🔴 Please review

See the files view or the action log for details.

Unrecognized words (1)

amazonvpc

Available dictionaries could cover words not in the dictionary

cspell:cpp/cpp.txt (104293) covers 55 of them
cspell:java/java.txt (33524) covers 8 of them
cspell:django/django.txt (2342) covers 8 of them
cspell:html/html.txt (542) covers 6 of them
cspell:scala/scala.txt (2752) covers 5 of them
cspell:python/python.txt (364) covers 5 of them
cspell:fullstack/fullstack.txt (181) covers 5 of them
cspell:filetypes/filetypes.txt (337) covers 5 of them
cspell:css/css.txt (993) covers 5 of them
cspell:lua/lua.txt (391) covers 4 of them
cspell:rust/rust.txt (112) covers 2 of them
cspell:ruby/ruby.txt (354) covers 2 of them
cspell:npm/npm.txt (671) covers 2 of them
cspell:node/node.txt (9611) covers 2 of them
cspell:bash/bash-words.txt (22) covers 2 of them
cspell:csharp/csharp.txt (123) covers 1 of them
cspell:ada/ada.txt (72) covers 1 of them

Consider adding them using:

      with:
        extra_dictionaries:
          cspell:cpp/cpp.txt
          cspell:java/java.txt
          cspell:django/django.txt
          cspell:html/html.txt
          cspell:scala/scala.txt
          cspell:python/python.txt
          cspell:fullstack/fullstack.txt
          cspell:filetypes/filetypes.txt
          cspell:css/css.txt
          cspell:lua/lua.txt
          cspell:rust/rust.txt
          cspell:ruby/ruby.txt
          cspell:npm/npm.txt
          cspell:node/node.txt
          cspell:bash/bash-words.txt
          cspell:csharp/csharp.txt
          cspell:ada/ada.txt

To stop checking additional dictionaries, add:

      with:
        check_extra_dictionaries: ''
To accept these unrecognized words as correct, run the following commands

... in a clone of the [email protected]:tokiwong/karpenter.git repository
on the fix-webhook-env-indents branch:

update_files() {
perl -e '
my $new_expect_file=".github/actions/spelling/expect.txt";
use File::Path qw(make_path);
use File::Basename qw(dirname);
make_path (dirname($new_expect_file));
open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
my @add=qw('"$patch_add"');
my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
@words = sort {lc($a)."-".$a cmp lc($b)."-".$b} keys %items;
open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
close FILE;
system("git", "add", $new_expect_file);
'
}

comment_json=$(mktemp)
curl -L -s -S \
-H "Content-Type: application/json" \
"https://api.github.com/repos/aws/karpenter/issues/comments/1004907442" > "$comment_json"
comment_body=$(mktemp)
jq -r ".body // empty" "$comment_json" > $comment_body
rm $comment_json

patch_add=$(perl -e '$/=undef; $_=<>; if (m{Unrecognized words[^<]*</summary>\n*```\n*([^<]*)```\n*</details>$}m) { print "$1" } elsif (m{Unrecognized words[^<]*\n\n((?:\w.*\n)+)\n}m) { print "$1" };' < "$comment_body")

update_files
rm $comment_body
git add -u
If the flagged items do not appear to be text

If items relate to a ...

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

  • binary file.

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

@ellistarn ellistarn merged commit b1727fe into aws:main Jan 4, 2022
@tokiwong tokiwong deleted the fix-webhook-env-indents branch January 4, 2022 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants