Sped up tests by 1.5seconds/test #1060

ellistarn · 2021-12-30T22:20:25Z

1. Issue, if available:

2. Description of changes:

ginkgo -r
[1640902878] Validation - 19/19 specs ••••••••••••••••••• SUCCESS! 1.219976ms PASS
[1640902878] CloudProvider/AWS - 24/24 specs •••••••••••••••••••••••• SUCCESS! 17.236281736s PASS
[1640902878] Node - 18/18 specs •••••••••••••••••• SUCCESS! 14.276780199s PASS
[1640902878] Controllers/Provisioning - 11/11 specs ••••••••••• SUCCESS! 16.538455717s PASS
PASS
testing: warning: no tests to run
Found no test suites, did you forget to run "ginkgo bootstrap"?[1640902878] Controllers/Scheduling - 39/39 specs ••••••••••••••••S•••••••••••••••••••••• SUCCESS! 40.300813943s PASS
[1640902878] Controllers/Scheduling - 3/3 specs ••• SUCCESS! 15.463171157s PASS
[1640902878] Termination - 6/6 specs •••••• SUCCESS! 15.919283898s PASS
[1640902878] Functional Suite - 10/10 specs •••••••••• SUCCESS! 414.383µs PASS

Ginkgo ran 9 suites in 2m13.910061006s
Test Suite Passed

3. Does this change impact docs?

Yes, PR includes docs updates
Yes, issue opened: link to issue
No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

netlify · 2021-12-30T22:20:31Z

✔️ Deploy Preview for karpenter-docs-prod canceled.

🔨 Explore the source changes: 198a014

🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/61ce39f58b8aeb00081f825e

github-actions · 2021-12-30T22:21:12Z

@check-spelling-bot Report

🔴 Please review

See the files view or the action log for details.

Unrecognized words (1)

enviction

Available dictionaries could cover words not in the dictionary

cspell:cpp/cpp.txt (104293) covers 72 of them
cspell:aws/aws.txt (1485) covers 30 of them
cspell:golang/go.txt (7745) covers 18 of them
cspell:django/django.txt (2342) covers 17 of them
cspell:filetypes/filetypes.txt (337) covers 11 of them
cspell:html/html.txt (542) covers 9 of them
cspell:css/css.txt (993) covers 9 of them
cspell:java/java.txt (33524) covers 8 of them
cspell:fullstack/fullstack.txt (181) covers 7 of them
cspell:python/python.txt (364) covers 6 of them
cspell:lua/lua.txt (391) covers 6 of them
cspell:scala/scala.txt (2752) covers 5 of them
cspell:npm/npm.txt (671) covers 5 of them
cspell:csharp/csharp.txt (123) covers 3 of them
cspell:rust/rust.txt (112) covers 2 of them
cspell:ruby/ruby.txt (354) covers 2 of them
cspell:node/node.txt (9611) covers 2 of them
cspell:bash/bash-words.txt (22) covers 2 of them
cspell:php/php.txt (9785) covers 1 of them
cspell:dotnet/dotnet.txt (9824) covers 1 of them
cspell:ada/ada.txt (72) covers 1 of them

Consider adding them using:

      with:
        extra_dictionaries:
          cspell:cpp/cpp.txt
          cspell:aws/aws.txt
          cspell:golang/go.txt
          cspell:django/django.txt
          cspell:filetypes/filetypes.txt
          cspell:html/html.txt
          cspell:css/css.txt
          cspell:java/java.txt
          cspell:fullstack/fullstack.txt
          cspell:python/python.txt
          cspell:lua/lua.txt
          cspell:scala/scala.txt
          cspell:npm/npm.txt
          cspell:csharp/csharp.txt
          cspell:rust/rust.txt
          cspell:ruby/ruby.txt
          cspell:node/node.txt
          cspell:bash/bash-words.txt
          cspell:php/php.txt
          cspell:dotnet/dotnet.txt
          cspell:ada/ada.txt

To stop checking additional dictionaries, add:

      with:
        check_extra_dictionaries: ''

To accept these unrecognized words as correct, run the following commands

... in a clone of the [email protected]:ellistarn/karpenter.git repository
on the fasttest branch:

update_files() {
perl -e '
my $new_expect_file=".github/actions/spelling/expect.txt";
use File::Path qw(make_path);
use File::Basename qw(dirname);
make_path (dirname($new_expect_file));
open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
my @add=qw('"$patch_add"');
my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
@words = sort {lc($a)."-".$a cmp lc($b)."-".$b} keys %items;
open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
close FILE;
system("git", "add", $new_expect_file);
'
}

comment_json=$(mktemp)
curl -L -s -S \
-H "Content-Type: application/json" \
"https://api.github.com/repos/aws/karpenter/issues/comments/1003199110" > "$comment_json"
comment_body=$(mktemp)
jq -r ".body // empty" "$comment_json" > $comment_body
rm $comment_json

patch_add=$(perl -e '$/=undef; $_=<>; if (m{Unrecognized words[^<]*</summary>\n*```\n*([^<]*)```\n*</details>$}m) { print "$1" } elsif (m{Unrecognized words[^<]*\n\n((?:\w.*\n)+)\n}m) { print "$1" };' < "$comment_body")

update_files
rm $comment_body
git add -u

If the flagged items do not appear to be text

If items relate to a ...

well-formed pattern.

If you can write a pattern that would match it,
try adding it to the patterns.txt file.

Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

Note that patterns can't match multiline strings.
binary file.

Please add a file path to the excludes.txt file matching the containing file.

File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

njtran · 2021-12-30T22:28:26Z

pkg/test/expectations/expectations.go

+	} {
+		wg.Add(1)
+		go func(object client.Object) {
+			Expect(c.DeleteAllOf(ctx, object, client.InNamespace("default"))).ToNot(HaveOccurred())


Why are we restricting just to the default namespace here? Shouldn't we be deleting every namespace (regardless if we have tests with non-default namespaces or not) when we clean up?

The DeleteAllOf api call requires all namespaces. I suppose you're right that I should describe all namespaces and include them.

pkg/test/expectations/expectations.go

github-actions · 2021-12-30T22:39:29Z

@check-spelling-bot Report

🔴 Please review

See the files view or the action log for details.

Unrecognized words (1)

enviction

Available dictionaries could cover words not in the dictionary

cspell:cpp/cpp.txt (104293) covers 72 of them
cspell:aws/aws.txt (1485) covers 30 of them
cspell:golang/go.txt (7745) covers 18 of them
cspell:django/django.txt (2342) covers 17 of them
cspell:filetypes/filetypes.txt (337) covers 11 of them
cspell:html/html.txt (542) covers 9 of them
cspell:css/css.txt (993) covers 9 of them
cspell:java/java.txt (33524) covers 8 of them
cspell:fullstack/fullstack.txt (181) covers 7 of them
cspell:python/python.txt (364) covers 6 of them
cspell:lua/lua.txt (391) covers 6 of them
cspell:scala/scala.txt (2752) covers 5 of them
cspell:npm/npm.txt (671) covers 5 of them
cspell:csharp/csharp.txt (123) covers 3 of them
cspell:rust/rust.txt (112) covers 2 of them
cspell:ruby/ruby.txt (354) covers 2 of them
cspell:node/node.txt (9611) covers 2 of them
cspell:bash/bash-words.txt (22) covers 2 of them
cspell:php/php.txt (9785) covers 1 of them
cspell:dotnet/dotnet.txt (9824) covers 1 of them
cspell:ada/ada.txt (72) covers 1 of them

Consider adding them using:

      with:
        extra_dictionaries:
          cspell:cpp/cpp.txt
          cspell:aws/aws.txt
          cspell:golang/go.txt
          cspell:django/django.txt
          cspell:filetypes/filetypes.txt
          cspell:html/html.txt
          cspell:css/css.txt
          cspell:java/java.txt
          cspell:fullstack/fullstack.txt
          cspell:python/python.txt
          cspell:lua/lua.txt
          cspell:scala/scala.txt
          cspell:npm/npm.txt
          cspell:csharp/csharp.txt
          cspell:rust/rust.txt
          cspell:ruby/ruby.txt
          cspell:node/node.txt
          cspell:bash/bash-words.txt
          cspell:php/php.txt
          cspell:dotnet/dotnet.txt
          cspell:ada/ada.txt

To stop checking additional dictionaries, add:

      with:
        check_extra_dictionaries: ''

To accept these unrecognized words as correct, run the following commands

... in a clone of the [email protected]:ellistarn/karpenter.git repository
on the fasttest branch:

update_files() {
perl -e '
my $new_expect_file=".github/actions/spelling/expect.txt";
use File::Path qw(make_path);
use File::Basename qw(dirname);
make_path (dirname($new_expect_file));
open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
my @add=qw('"$patch_add"');
my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
@words = sort {lc($a)."-".$a cmp lc($b)."-".$b} keys %items;
open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
close FILE;
system("git", "add", $new_expect_file);
'
}

comment_json=$(mktemp)
curl -L -s -S \
-H "Content-Type: application/json" \
"https://api.github.com/repos/aws/karpenter/issues/comments/1003202498" > "$comment_json"
comment_body=$(mktemp)
jq -r ".body // empty" "$comment_json" > $comment_body
rm $comment_json

patch_add=$(perl -e '$/=undef; $_=<>; if (m{Unrecognized words[^<]*</summary>\n*```\n*([^<]*)```\n*</details>$}m) { print "$1" } elsif (m{Unrecognized words[^<]*\n\n((?:\w.*\n)+)\n}m) { print "$1" };' < "$comment_body")

update_files
rm $comment_body
git add -u

If the flagged items do not appear to be text

If items relate to a ...

well-formed pattern.

If you can write a pattern that would match it,
try adding it to the patterns.txt file.

Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

Note that patterns can't match multiline strings.
binary file.

Please add a file path to the excludes.txt file matching the containing file.

File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

github-actions · 2021-12-30T22:40:30Z

@check-spelling-bot Report

🔴 Please review

See the files view or the action log for details.

Unrecognized words (1)

enviction

Available dictionaries could cover words not in the dictionary

cspell:cpp/cpp.txt (104293) covers 72 of them
cspell:aws/aws.txt (1485) covers 30 of them
cspell:golang/go.txt (7745) covers 18 of them
cspell:django/django.txt (2342) covers 17 of them
cspell:filetypes/filetypes.txt (337) covers 11 of them
cspell:html/html.txt (542) covers 9 of them
cspell:css/css.txt (993) covers 9 of them
cspell:java/java.txt (33524) covers 8 of them
cspell:fullstack/fullstack.txt (181) covers 7 of them
cspell:python/python.txt (364) covers 6 of them
cspell:lua/lua.txt (391) covers 6 of them
cspell:scala/scala.txt (2752) covers 5 of them
cspell:npm/npm.txt (671) covers 5 of them
cspell:csharp/csharp.txt (123) covers 3 of them
cspell:rust/rust.txt (112) covers 2 of them
cspell:ruby/ruby.txt (354) covers 2 of them
cspell:node/node.txt (9611) covers 2 of them
cspell:bash/bash-words.txt (22) covers 2 of them
cspell:php/php.txt (9785) covers 1 of them
cspell:dotnet/dotnet.txt (9824) covers 1 of them
cspell:ada/ada.txt (72) covers 1 of them

Consider adding them using:

      with:
        extra_dictionaries:
          cspell:cpp/cpp.txt
          cspell:aws/aws.txt
          cspell:golang/go.txt
          cspell:django/django.txt
          cspell:filetypes/filetypes.txt
          cspell:html/html.txt
          cspell:css/css.txt
          cspell:java/java.txt
          cspell:fullstack/fullstack.txt
          cspell:python/python.txt
          cspell:lua/lua.txt
          cspell:scala/scala.txt
          cspell:npm/npm.txt
          cspell:csharp/csharp.txt
          cspell:rust/rust.txt
          cspell:ruby/ruby.txt
          cspell:node/node.txt
          cspell:bash/bash-words.txt
          cspell:php/php.txt
          cspell:dotnet/dotnet.txt
          cspell:ada/ada.txt

To stop checking additional dictionaries, add:

      with:
        check_extra_dictionaries: ''

To accept these unrecognized words as correct, run the following commands

... in a clone of the [email protected]:ellistarn/karpenter.git repository
on the fasttest branch:

update_files() {
perl -e '
my $new_expect_file=".github/actions/spelling/expect.txt";
use File::Path qw(make_path);
use File::Basename qw(dirname);
make_path (dirname($new_expect_file));
open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
my @add=qw('"$patch_add"');
my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
@words = sort {lc($a)."-".$a cmp lc($b)."-".$b} keys %items;
open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
close FILE;
system("git", "add", $new_expect_file);
'
}

comment_json=$(mktemp)
curl -L -s -S \
-H "Content-Type: application/json" \
"https://api.github.com/repos/aws/karpenter/issues/comments/1003202666" > "$comment_json"
comment_body=$(mktemp)
jq -r ".body // empty" "$comment_json" > $comment_body
rm $comment_json

patch_add=$(perl -e '$/=undef; $_=<>; if (m{Unrecognized words[^<]*</summary>\n*```\n*([^<]*)```\n*</details>$}m) { print "$1" } elsif (m{Unrecognized words[^<]*\n\n((?:\w.*\n)+)\n}m) { print "$1" };' < "$comment_body")

update_files
rm $comment_body
git add -u

If the flagged items do not appear to be text

If items relate to a ...

well-formed pattern.

If you can write a pattern that would match it,
try adding it to the patterns.txt file.

Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

Note that patterns can't match multiline strings.
binary file.

Please add a file path to the excludes.txt file matching the containing file.

File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

github-actions · 2021-12-30T23:00:47Z

@check-spelling-bot Report

🔴 Please review

See the files view or the action log for details.

Unrecognized words (1)

enviction

Available dictionaries could cover words not in the dictionary

cspell:cpp/cpp.txt (104293) covers 72 of them
cspell:aws/aws.txt (1485) covers 30 of them
cspell:golang/go.txt (7745) covers 18 of them
cspell:django/django.txt (2342) covers 17 of them
cspell:filetypes/filetypes.txt (337) covers 11 of them
cspell:html/html.txt (542) covers 9 of them
cspell:css/css.txt (993) covers 9 of them
cspell:java/java.txt (33524) covers 8 of them
cspell:fullstack/fullstack.txt (181) covers 7 of them
cspell:python/python.txt (364) covers 6 of them
cspell:lua/lua.txt (391) covers 6 of them
cspell:scala/scala.txt (2752) covers 5 of them
cspell:npm/npm.txt (671) covers 5 of them
cspell:csharp/csharp.txt (123) covers 3 of them
cspell:rust/rust.txt (112) covers 2 of them
cspell:ruby/ruby.txt (354) covers 2 of them
cspell:node/node.txt (9611) covers 2 of them
cspell:bash/bash-words.txt (22) covers 2 of them
cspell:php/php.txt (9785) covers 1 of them
cspell:dotnet/dotnet.txt (9824) covers 1 of them
cspell:ada/ada.txt (72) covers 1 of them

Consider adding them using:

      with:
        extra_dictionaries:
          cspell:cpp/cpp.txt
          cspell:aws/aws.txt
          cspell:golang/go.txt
          cspell:django/django.txt
          cspell:filetypes/filetypes.txt
          cspell:html/html.txt
          cspell:css/css.txt
          cspell:java/java.txt
          cspell:fullstack/fullstack.txt
          cspell:python/python.txt
          cspell:lua/lua.txt
          cspell:scala/scala.txt
          cspell:npm/npm.txt
          cspell:csharp/csharp.txt
          cspell:rust/rust.txt
          cspell:ruby/ruby.txt
          cspell:node/node.txt
          cspell:bash/bash-words.txt
          cspell:php/php.txt
          cspell:dotnet/dotnet.txt
          cspell:ada/ada.txt

To stop checking additional dictionaries, add:

      with:
        check_extra_dictionaries: ''

To accept these unrecognized words as correct, run the following commands

... in a clone of the [email protected]:ellistarn/karpenter.git repository
on the fasttest branch:

update_files() {
perl -e '
my $new_expect_file=".github/actions/spelling/expect.txt";
use File::Path qw(make_path);
use File::Basename qw(dirname);
make_path (dirname($new_expect_file));
open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
my @add=qw('"$patch_add"');
my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
@words = sort {lc($a)."-".$a cmp lc($b)."-".$b} keys %items;
open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
close FILE;
system("git", "add", $new_expect_file);
'
}

comment_json=$(mktemp)
curl -L -s -S \
-H "Content-Type: application/json" \
"https://api.github.com/repos/aws/karpenter/issues/comments/1003206399" > "$comment_json"
comment_body=$(mktemp)
jq -r ".body // empty" "$comment_json" > $comment_body
rm $comment_json

patch_add=$(perl -e '$/=undef; $_=<>; if (m{Unrecognized words[^<]*</summary>\n*```\n*([^<]*)```\n*</details>$}m) { print "$1" } elsif (m{Unrecognized words[^<]*\n\n((?:\w.*\n)+)\n}m) { print "$1" };' < "$comment_body")

update_files
rm $comment_body
git add -u

If the flagged items do not appear to be text

If items relate to a ...

well-formed pattern.

If you can write a pattern that would match it,
try adding it to the patterns.txt file.

Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

Note that patterns can't match multiline strings.
binary file.

Please add a file path to the excludes.txt file matching the containing file.

File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

jsoref · 2021-12-31T00:31:10Z

Fwiw, enviction was here:
https://github.com/aws/karpenter/blob/b63346cd662d5d5371b1906792f60dc12957ba3c/pkg/controllers/termination/suite_test.go#L219

ellistarn · 2021-12-31T00:32:33Z

enviction

Odd -- I tried to find/replace multiple times and couldn't find it. Found it now.

jsoref · 2021-12-31T00:34:33Z

It's in the main branch as opposed to in the PR.

ellistarn · 2021-12-31T00:58:33Z

It's in the main branch as opposed to in the PR.

Do you have a slack where I can ask some questions on spelling? I'm on the Kubernetes slack ellistarn.

jsoref · 2021-12-31T01:16:22Z

Just found you on that slack. I'm jsoref.

Sped up tests by 1.5seconds/test

ab2453e

njtran reviewed Dec 30, 2021

View reviewed changes

pkg/test/expectations/expectations.go Show resolved Hide resolved

PR Comments

95d0273

ellistarn mentioned this pull request Dec 30, 2021

Spelling giving misleading/hard to understand errors check-spelling/check-spelling#21

Closed

PR Comments

198a014

ellistarn force-pushed the fasttest branch from b23c1a5 to 198a014 Compare December 30, 2021 23:00

ellistarn enabled auto-merge (squash) December 31, 2021 00:25

njtran approved these changes Dec 31, 2021

View reviewed changes

ellistarn merged commit 75afd60 into aws:main Dec 31, 2021

ellistarn deleted the fasttest branch December 31, 2021 00:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sped up tests by 1.5seconds/test #1060

Sped up tests by 1.5seconds/test #1060

ellistarn commented Dec 30, 2021 •

edited

Loading

netlify bot commented Dec 30, 2021 •

edited

Loading

github-actions bot commented Dec 30, 2021 •

edited

Loading

njtran Dec 30, 2021

ellistarn Dec 30, 2021

github-actions bot commented Dec 30, 2021 •

edited

Loading

github-actions bot commented Dec 30, 2021 •

edited

Loading

github-actions bot commented Dec 30, 2021 •

edited

Loading

jsoref commented Dec 31, 2021

ellistarn commented Dec 31, 2021

jsoref commented Dec 31, 2021

ellistarn commented Dec 31, 2021

jsoref commented Dec 31, 2021

Sped up tests by 1.5seconds/test #1060

Sped up tests by 1.5seconds/test #1060

Conversation

ellistarn commented Dec 30, 2021 • edited Loading

netlify bot commented Dec 30, 2021 • edited Loading

github-actions bot commented Dec 30, 2021 • edited Loading

@check-spelling-bot Report

🔴 Please review

Unrecognized words (1)

njtran Dec 30, 2021

Choose a reason for hiding this comment

ellistarn Dec 30, 2021

Choose a reason for hiding this comment

github-actions bot commented Dec 30, 2021 • edited Loading

@check-spelling-bot Report

🔴 Please review

Unrecognized words (1)

github-actions bot commented Dec 30, 2021 • edited Loading

@check-spelling-bot Report

🔴 Please review

Unrecognized words (1)

github-actions bot commented Dec 30, 2021 • edited Loading

@check-spelling-bot Report

🔴 Please review

Unrecognized words (1)

jsoref commented Dec 31, 2021

ellistarn commented Dec 31, 2021

jsoref commented Dec 31, 2021

ellistarn commented Dec 31, 2021

jsoref commented Dec 31, 2021

ellistarn commented Dec 30, 2021 •

edited

Loading

netlify bot commented Dec 30, 2021 •

edited

Loading

github-actions bot commented Dec 30, 2021 •

edited

Loading

github-actions bot commented Dec 30, 2021 •

edited

Loading

github-actions bot commented Dec 30, 2021 •

edited

Loading

github-actions bot commented Dec 30, 2021 •

edited

Loading