Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set aside pods that fail to pack to avoid continually retrying and failing to pack them. #412

Closed
ellistarn opened this issue May 18, 2021 · 1 comment · Fixed by #503
Closed
Milestone

Comments

@ellistarn
Copy link
Contributor

Logs can get really noisy with Failed to compute packing for pod(s) ..., let's set pods aside if they fail to pack for some TTL.

@ellistarn ellistarn added the v0.3 label Jun 3, 2021
@njtran
Copy link
Contributor

njtran commented Jun 3, 2021

This issue should be solved in v0.3 with our switch to watch events to trigger controller actions as detailed in this design.

Karpenter would watch events requiring pod scheduling and bin packing decisions, and then trigger the allocation controller to do some work. If there are pods that are unable to fit into a bin packing solution, we will execute the bin packing solution for the pods that fit, then exponentially backoff and retry for the pods that did not fit.

@akestner akestner added this to the v0.3.0 milestone Jun 13, 2021
gfcroft pushed a commit to gfcroft/karpenter-provider-aws that referenced this issue Nov 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants