Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature-request] - helm search repo should show the app version #1048

Closed
vikas027 opened this issue Dec 28, 2021 · 3 comments
Closed

[feature-request] - helm search repo should show the app version #1048

vikas027 opened this issue Dec 28, 2021 · 3 comments
Labels
feature New feature or request good-first-issue Good for newcomers help-wanted Extra attention is needed

Comments

@vikas027
Copy link

As of now, the app version is not shown in the while searching the helm repo, it will be great to have the same.

❯ helm search repo karpenter
NAME                    CHART VERSION   APP VERSION     DESCRIPTION                                       
karpenter/karpenter     0.5.3                           A Helm chart for https://github.com/aws/karpent...
@vikas027 vikas027 added the feature New feature or request label Dec 28, 2021
@ellistarn ellistarn added good-first-issue Good for newcomers help-wanted Extra attention is needed labels Dec 28, 2021
huiser added a commit to huiser/karpenter that referenced this issue Dec 28, 2021
@huiser
helm search repo should show the app version (aws#1048)
3abef12
@huiser huiser mentioned this issue Dec 28, 2021
Merged
3 tasks
ellistarn pushed a commit that referenced this issue Dec 28, 2021
@huiser
helm search repo should show the app version (#1048) (#1049)
360eaef 
* helm search repo should show the app version (#1048)

* Update chart appVersion variable @ release
@joekr
Copy link

joekr commented Jan 8, 2022 •
edited
Loading

It looks like the above commit added the feature: https://github.com/aws/karpenter/blob/main/charts/karpenter/Chart.yaml#L2

➜ helm search repo karpenter
NAME               	CHART VERSION	APP VERSION	DESCRIPTION
karpenter/karpenter	0.5.4        	0.5.4      	A Helm chart for https://github.com/aws/karpent...

@mikesir87
Copy link
Contributor

Yup. It's working now. Looks like the PR just didn't close this issue /cc @ellistarn

@ellistarn
Copy link
Contributor

Thanks all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New feature or request good-first-issue Good for newcomers help-wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@joekr @mikesir87 @ellistarn @vikas027