Logging improvements (#568)

aws · Jul 29, 2021 · 9e718d3 · 9e718d3
1 parent b1f89b7
commit 9e718d3
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/pkg/cloudprovider/aws/instance.go b/pkg/cloudprovider/aws/instance.go
@@ -134,7 +134,7 @@ func getInstanceID(node *v1.Node) (*string, error) {
 func combineFleetErrors(errors []*ec2.CreateFleetError) (errs error) {
 	unique := sets.NewString()
 	for _, err := range errors {
-		unique.Insert(aws.StringValue(err.ErrorCode))
+		unique.Insert(fmt.Sprintf("%s: %s", aws.StringValue(err.ErrorCode), aws.StringValue(err.ErrorMessage)))
 	}
 	for _, errorCode := range unique.List() {
 		errs = multierr.Append(errs, fmt.Errorf(errorCode))

diff --git a/pkg/controllers/allocation/filter.go b/pkg/controllers/allocation/filter.go
@@ -45,10 +45,8 @@ func (f *Filter) GetProvisionablePods(ctx context.Context, provisioner *v1alpha3
 	provisionable := []*v1.Pod{}
 	for _, p := range pods.Items {
 		if err := f.isProvisionable(ctx, &p, provisioner); err != nil {
-			logging.FromContext(ctx).Debugf("Ignored pod %s/%s when allocating for provisioner %s/%s, %s",
-				p.Name, p.Namespace,
-				provisioner.Name, provisioner.Namespace,
-				err.Error(),
+			logging.FromContext(ctx).Debugf("Ignored pod %s/%s when allocating for provisioner %s, %s",
+				p.Name, p.Namespace, provisioner.Name, err.Error(),
 			)
 			continue
 		}