Skip to content

Commit

Permalink
Reuse the upgrade script, and add trailing backslash where its missing (
Browse files Browse the repository at this point in the history
#1478)

* Reuse the upgrade script, and add trailing backslash where its missing
  • Loading branch information
spring1843 authored Mar 7, 2022
1 parent e16de47 commit 2041bb5
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 12 deletions.
2 changes: 1 addition & 1 deletion charts/karpenter/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ You can follow the detailed installation instruction in the [documentation](http
helm upgrade --install --namespace karpenter --create-namespace \
karpenter karpenter/karpenter \
--version 0.6.4 \
--set serviceAccount.annotations.eks\.amazonaws\.com/role-arn=${KARPENTER_IAM_ROLE_ARN}
--set serviceAccount.annotations.eks\.amazonaws\.com/role-arn=${KARPENTER_IAM_ROLE_ARN} \
--set clusterName=${CLUSTER_NAME} \
--set clusterEndpoint=${CLUSTER_ENDPOINT} \
--set aws.defaultInstanceProfile=KarpenterNodeInstanceProfile-${CLUSTER_NAME} \
Expand Down
2 changes: 1 addition & 1 deletion charts/karpenter/README.md.gotmpl
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ You can follow the detailed installation instruction in the [documentation](http
helm upgrade --install --namespace karpenter --create-namespace \
karpenter karpenter/{{ template "chart.name" . }} \
--version {{ template "chart.version" . }} \
--set serviceAccount.annotations.eks\.amazonaws\.com/role-arn=${KARPENTER_IAM_ROLE_ARN}
--set serviceAccount.annotations.eks\.amazonaws\.com/role-arn=${KARPENTER_IAM_ROLE_ARN} \
--set clusterName=${CLUSTER_NAME} \
--set clusterEndpoint=${CLUSTER_ENDPOINT} \
--set aws.defaultInstanceProfile=KarpenterNodeInstanceProfile-${CLUSTER_NAME} \
Expand Down
11 changes: 1 addition & 10 deletions website/content/en/preview/faq.md
Original file line number Diff line number Diff line change
Expand Up @@ -137,13 +137,4 @@ Use your existing upgrade mechanisms to upgrade your core add-ons in Kubernetes
Karpenter requires proper permissions in the `KarpenterNode IAM Role` and the `KarpenterController IAM Role`.
To upgrade Karpenter to version `$VERSION`, make sure that the `KarpenterNode IAM Role` and the `KarpenterController IAM Role` have the right permission described in `https://karpenter.sh/$VERSION/getting-started/cloudformation.yaml`.
Next, locate `KarpenterController IAM Role` ARN (i.e., ARN of the resource created in [Create the KarpenterController IAM Role](../getting-started/getting-started-with-eksctl/#create-the-karpentercontroller-iam-role)) and the cluster endpoint, and pass them to the helm upgrade command
```
helm upgrade --install --namespace karpenter --create-namespace \
karpenter karpenter/karpenter \
--version ${$VERSION} \
--set clusterName=${CLUSTER_NAME} \
--set clusterEndpoint=${CLUSTER_ENDPOINT} \
--set serviceAccount.annotations.eks\.amazonaws\.com/role-arn=${KARPENTER_IAM_ROLE_ARN}
--set aws.defaultInstanceProfile=KarpenterNodeInstanceProfile-${CLUSTER_NAME} \
--wait # for the defaulting webhook to install before creating a Provisioner
```
{{% script file="./content/en/preview/getting-started/getting-started-with-eksctl/scripts/step08-apply-helm-chart.sh" language="bash"%}}

0 comments on commit 2041bb5

Please sign in to comment.