addressed feedback

aws · Nov 25, 2024 · 181c854 · 181c854
1 parent 0bfce9b
commit 181c854
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/pkg/test/environment.go b/pkg/test/environment.go
@@ -117,6 +117,9 @@ func NewEnvironment(ctx context.Context, env *coretest.Environment) *Environment
 	subnetProvider := subnet.NewDefaultProvider(ec2api, subnetCache, availableIPAdressCache, associatePublicIPAddressCache)
 	securityGroupProvider := securitygroup.NewDefaultProvider(ec2api, securityGroupCache)
 	versionProvider := version.NewDefaultProvider(env.KubernetesInterface, eksapi)
+	// Ensure we're able to hydrate the version before starting any reliant controllers.
+	// Version updates are hydrated asynchronously after this, in the event of a failure
+	// the previously resolved value will be used.
 	lo.Must0(versionProvider.UpdateVersion(ctx))
 	instanceProfileProvider := instanceprofile.NewDefaultProvider(fake.DefaultRegion, iamapi, instanceProfileCache)
 	ssmProvider := ssmp.NewDefaultProvider(ssmapi, ssmCache)