fix(java): remove Jackson confusion with certain patterns #987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upon deserializing (`ObjectMapper#treeToValue`), Jackson will first validate the `valueType` for whether ti can be deserialized with the "standard" bean deserializer. This will bail out if there are multiple ambiguous setters for a given property (they are ambiguous if they have parameters of non-trivial types, such as `List`, some class, ...). In order to remove the problem, this changes the deserialization path so that instead of asking for deserialization into the needed instance type directly, `JsiiObject` will be requested instead when the declared type is a sub-class of that. Since such types are passed by-reference, the custom de-serializer modifier will correctly determine the "right" class to use (the declared type, or a subtype of it), and return this... But Jackson will not get the chance to be confused or unhappy about that type's structure. This was the root cause of aws/aws-cdk#4080
rix0rrr
reviewed
Nov 14, 2019
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
rix0rrr
approved these changes
Nov 14, 2019
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
eladb
pushed a commit
that referenced
this pull request
Nov 18, 2019
…)" This reverts commit a8096b7.
eladb
pushed a commit
that referenced
this pull request
Nov 18, 2019
|
When is this revert going to be reverted? |
rix0rrr
pushed a commit
that referenced
this pull request
Nov 26, 2019
(Reintroduce #987). Upon deserializing (`ObjectMapper#treeToValue`), Jackson will first validate the `valueType` for whether ti can be deserialized with the "standard" bean deserializer. This will bail out if there are multiple ambiguous setters for a given property (they are ambiguous if they have parameters of non-trivial types, such as `List`, some class, ...). In order to remove the problem, this changes the deserialization path so that instead of asking for deserialization into the needed instance type directly, `JsiiObject` will be requested instead when the declared type is a sub-class of that. Since such types are passed by-reference, the custom de-serializer modifier will correctly determine the "right" class to use (the declared type, or a subtype of it), and return this... But Jackson will not get the chance to be confused or unhappy about that type's structure. This was the root cause of aws/aws-cdk#4080
mergify bot
pushed a commit
that referenced
this pull request
Nov 26, 2019
(Reintroduce #987). Upon deserializing (`ObjectMapper#treeToValue`), Jackson will first validate the `valueType` for whether ti can be deserialized with the "standard" bean deserializer. This will bail out if there are multiple ambiguous setters for a given property (they are ambiguous if they have parameters of non-trivial types, such as `List`, some class, ...). In order to remove the problem, this changes the deserialization path so that instead of asking for deserialization into the needed instance type directly, `JsiiObject` will be requested instead when the declared type is a sub-class of that. Since such types are passed by-reference, the custom de-serializer modifier will correctly determine the "right" class to use (the declared type, or a subtype of it), and return this... But Jackson will not get the chance to be confused or unhappy about that type's structure. This was the root cause of aws/aws-cdk#4080
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upon deserializing (
ObjectMapper#treeToValue), Jackson will firstvalidate the
valueTypefor whether ti can be deserialized with the"standard" bean deserializer. This will bail out if there are multiple
ambiguous setters for a given property (they are ambiguous if they have
parameters of non-trivial types, such as
List, some class, ...).In order to remove the problem, this changes the deserialization path so
that instead of asking for deserialization into the needed instance type
directly,
JsiiObjectwill be requested instead when the declared typeis a sub-class of that. Since such types are passed by-reference, the
custom de-serializer modifier will correctly determine the "right" class
to use (the declared type, or a subtype of it), and return this... But
Jackson will not get the chance to be confused or unhappy about that
type's structure.
This was the root cause of aws/aws-cdk#4080
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.