chore(release): 1.57.0 #3492
Merged
chore(release): 1.57.0 #3492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a struct pointer was passed in an `interface{}` position, the
converter would trip and register a new opaque instance of `Object`
instead of correctly serializing a struct.
This is because hte pointer is double-indirected (the `interface{}` is a
reference to the `&struct`, which is a reference to the `struct`). This
change adds a condition to detect such cases (`interface{}` abstracts
another pointer), and properly serialize that.
Fixes #2880
---
By submitting this pull request, I confirm that my contribution is made under the terms of the [Apache 2.0 license].
[Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0
While making the compiler fully synchronous (in #3467) a un-resolveable promise was removed which is used by `--watch`. When using watch mode, the typescript compiler creates a watcher, and hands back the control to the caller of watch, to allow caller to control the watcher instance. Since JSII does not do anything with the returned control, we need to return an un-resolveable promise which will keep the watcher running for ever (or till the whole program is killed) --- By submitting this pull request, I confirm that my contribution is made under the terms of the [Apache 2.0 license]. [Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0
…=8.2.9 in /gh-pages (#3479) Updates the requirements on [mkdocs-material](https://github.com/squidfunk/mkdocs-material) to permit the latest version. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/squidfunk/mkdocs-material/releases">mkdocs-material's releases</a>.</em></p> <blockquote> <h2>mkdocs-material-8.2.9</h2> <ul> <li>Mitigate flicker on color palette switch by disabling all transitions</li> <li>Fixed search suggestions not triggered when following deep link</li> <li>Fixed incorrectly computed header height when using instant loading</li> <li>Fixed <a href="https://github-redirect.dependabot.com/squidfunk/mkdocs-material/issues/3782">#3782</a>: Admonition titles have extra pixels on wide screens in Firefox</li> <li>Fixed <a href="https://github-redirect.dependabot.com/squidfunk/mkdocs-material/issues/3802">#3802</a>: Always render table of contents container (except when hidden)</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/squidfunk/mkdocs-material/blob/master/CHANGELOG">mkdocs-material's changelog</a>.</em></p> <blockquote> <p>mkdocs-material-8.2.9 (2022-04-08)</p> <ul> <li>Mitigate flicker on color palette switch by disabling all transitions</li> <li>Fixed search suggestions not triggered when following deep link</li> <li>Fixed incorrectly computed header height when using instant loading</li> <li>Fixed <a href="https://github-redirect.dependabot.com/squidfunk/mkdocs-material/issues/3782">#3782</a>: Admonition titles have extra pixels on wide screens in Firefox</li> <li>Fixed <a href="https://github-redirect.dependabot.com/squidfunk/mkdocs-material/issues/3802">#3802</a>: Always render table of contents container (except when hidden)</li> </ul> <p>mkdocs-material-8.2.8+insiders-4.12.0 (2022-03-27)</p> <ul> <li>Added support for card grids and grid layouts</li> <li>Fixed <a href="https://github-redirect.dependabot.com/squidfunk/mkdocs-material/issues/3685">#3685</a>: Annotations sometimes broken when using instant loading</li> <li>Fixed <a href="https://github-redirect.dependabot.com/squidfunk/mkdocs-material/issues/3742">#3742</a>: Automatically add Mermaid.js when building for offline usage</li> </ul> <p>mkdocs-material-8.2.8 (2022-03-27)</p> <ul> <li>Bumped MkDocs version to 1.3.0 to mitigate breaking changes in Jinja</li> <li>Reverted Jinja version range limitation (added in 8.2.7)</li> <li>Improved styling of annotations and fixed borders of code blocks in tabs</li> <li>Added background color to code blocks in focused/hovered links</li> <li>Added check in tags plugin whether tags overview page exists</li> <li>Fixed <a href="https://github-redirect.dependabot.com/squidfunk/mkdocs-material/issues/3744">#3744</a>: Content tab indicator on wrong position when using back button</li> </ul> <p>mkdocs-material-8.2.7 (2022-03-24)</p> <ul> <li>Temporarily limit Jinja version range to < 3.1 due to breaking changes</li> </ul> <p>mkdocs-material-8.2.6 (2022-03-23)</p> <ul> <li>Fixed <a href="https://github-redirect.dependabot.com/squidfunk/mkdocs-material/issues/3695">#3695</a>: Deprecation warning for unescaped backslashes in templates</li> <li>Fixed <a href="https://github-redirect.dependabot.com/squidfunk/mkdocs-material/issues/3696">#3696</a>: Annotations not mounted in some Terraform code blocks</li> <li>Fixed <a href="https://github-redirect.dependabot.com/squidfunk/mkdocs-material/issues/3698">#3698</a>: Annotations not mounted in long code blocks (8.2.5 regression)</li> </ul> <p>mkdocs-material-8.2.5+insiders-4.11.0 (2022-03-06)</p> <ul> <li>Added support for excluding external assets from privacy plugin</li> </ul> <p>mkdocs-material-8.2.5 (2022-03-06)</p> <ul> <li>Fixed <a href="https://github-redirect.dependabot.com/squidfunk/mkdocs-material/issues/3596">#3596</a>: Mermaid not working when headline with name 'Mermaid' present</li> <li>Fixed <a href="https://github-redirect.dependabot.com/squidfunk/mkdocs-material/issues/3643">#3643</a>: Reduce time to render pages with thousands of code blocks</li> <li>Fixed <a href="https://github-redirect.dependabot.com/squidfunk/mkdocs-material/issues/3665">#3665</a>: Missing styles for Mermaid.js flowcharts cluster labels</li> </ul> <p>mkdocs-material-8.2.4+insiders-4.10.1 (2022-03-02)</p> <ul> <li>Added missing build dependencies to Dockerfile</li> <li>Fixed encoding issues in privacy plugin, now forcing UTF-8 encoding</li> <li>Fixed <a href="https://github-redirect.dependabot.com/squidfunk/mkdocs-material/issues/3624">#3624</a>: Scroll to active navigation item unreliable in Firefox</li> <li>Fixed <a href="https://github-redirect.dependabot.com/squidfunk/mkdocs-material/issues/3642">#3642</a>: Privacy plugin errors when font setting was omitted</li> </ul> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/squidfunk/mkdocs-material/commit/007cbf845c4ee7045efc4049d7825e1fe2156e81"><code>007cbf8</code></a> Prepare 8.2.9 release</li> <li><a href="https://github.com/squidfunk/mkdocs-material/commit/d30cf5bd1350e0b3258e869a6740f7b70e6b43d0"><code>d30cf5b</code></a> Revert last commit</li> <li><a href="https://github.com/squidfunk/mkdocs-material/commit/f013fc6fbe19fef7540f2b24d9c84cfd7cc4e132"><code>f013fc6</code></a> Grant write permissions to documentation workflow</li> <li><a href="https://github.com/squidfunk/mkdocs-material/commit/a03650f4717850854694dbdb95d5c2a7e8bc1c2d"><code>a03650f</code></a> Grant write permissions to documentation workflow</li> <li><a href="https://github.com/squidfunk/mkdocs-material/commit/89e479d4825571b6f318cec5d3e89ef02ee79d3b"><code>89e479d</code></a> Bump minimist from 1.2.5 to 1.2.6 (<a href="https://github-redirect.dependabot.com/squidfunk/mkdocs-material/issues/3805">#3805</a>)</li> <li><a href="https://github.com/squidfunk/mkdocs-material/commit/1479e696c35dcb77f59e34ce76055d8770e36e10"><code>1479e69</code></a> Added permissions for GitHub actions (<a href="https://github-redirect.dependabot.com/squidfunk/mkdocs-material/issues/3804">#3804</a>)</li> <li><a href="https://github.com/squidfunk/mkdocs-material/commit/cc0f7a914a341566cbcd45d264ff062c7804956e"><code>cc0f7a9</code></a> Fixed incorrectly computed header height when using instant loading</li> <li><a href="https://github.com/squidfunk/mkdocs-material/commit/d926bb4c2791300548634bbd5f7d2ca23d997367"><code>d926bb4</code></a> Added button to view source of every page</li> <li><a href="https://github.com/squidfunk/mkdocs-material/commit/52adc006ba4e1d0177f845b020a676386418ab3d"><code>52adc00</code></a> Documentation</li> <li><a href="https://github.com/squidfunk/mkdocs-material/commit/dd2268f7acdb1b885b90d32648bbecc9b5cd2261"><code>dd2268f</code></a> Added alternate syntax to Insider plugins example (<a href="https://github-redirect.dependabot.com/squidfunk/mkdocs-material/issues/3783">#3783</a>)</li> <li>Additional commits viewable in <a href="https://github.com/squidfunk/mkdocs-material/compare/8.2.8...8.2.9">compare view</a></li> </ul> </details> <br /> Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) Dependabot will merge this PR once it's up-to-date and CI passes on it, as requested by @RomainMuller. [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 2 to 3. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/actions/upload-artifact/releases">actions/upload-artifact's releases</a>.</em></p> <blockquote> <h2>v3.0.0</h2> <h2>What's Changed</h2> <ul> <li>Update default runtime to node16 (<a href="https://github-redirect.dependabot.com/actions/upload-artifact/issues/293">#293</a>)</li> <li>Update package-lock.json file version to 2 (<a href="https://github-redirect.dependabot.com/actions/upload-artifact/issues/302">#302</a>)</li> </ul> <h3>Breaking Changes</h3> <p>With the update to Node 16, all scripts will now be run with Node 16 rather than Node 12.</p> <h2>v2.3.1</h2> <p>Fix for empty fails on Windows failing on upload <a href="https://github-redirect.dependabot.com/actions/upload-artifact/issues/281">#281</a></p> <h2>v2.3.0 Upload Artifact</h2> <ul> <li>Optimizations for faster uploads of larger files that are already compressed</li> <li>Significantly improved logging when there are chunked uploads</li> <li>Clarifications in logs around the upload size and prohibited characters that aren't allowed in the artifact name or any uploaded files</li> <li>Various other small bugfixes & optimizations</li> </ul> <h2>v2.2.4</h2> <ul> <li>Retry on HTTP 500 responses from the service</li> </ul> <h2>v2.2.3</h2> <ul> <li>Fixes for proxy related issues</li> </ul> <h2>v2.2.2</h2> <ul> <li>Improved retryability and error handling</li> </ul> <h2>v2.2.1</h2> <ul> <li>Update used actions/core package to the latest version</li> </ul> <h2>v2.2.0</h2> <ul> <li>Support for artifact retention</li> </ul> <h2>v2.1.4</h2> <ul> <li>Add Third Party License Information</li> </ul> <h2>v2.1.3</h2> <ul> <li>Use updated version of the <code>@action/artifact</code> NPM package</li> </ul> <h2>v2.1.2</h2> <ul> <li>Increase upload chunk size from 4MB to 8MB</li> <li>Detect case insensitive file uploads</li> </ul> <h2>v2.1.1</h2> <ul> <li>Fix for certain symlinks not correctly being identified as directories before starting uploads</li> </ul> <h2>v2.1.0</h2> <ul> <li>Support for uploading artifacts with multiple paths</li> <li>Support for using exclude paths</li> <li>Updates to dependencies</li> </ul> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/actions/upload-artifact/commit/6673cd052c4cd6fcf4b4e6e60ea986c889389535"><code>6673cd0</code></a> Update <code>lockfileVersion</code> in <code>package-lock.json</code> (<a href="https://github-redirect.dependabot.com/actions/upload-artifact/issues/302">#302</a>)</li> <li><a href="https://github.com/actions/upload-artifact/commit/2244c8200304ec9588bf9399eac622d9fadc28c4"><code>2244c82</code></a> Update to node16 (<a href="https://github-redirect.dependabot.com/actions/upload-artifact/issues/293">#293</a>)</li> <li><a href="https://github.com/actions/upload-artifact/commit/87348cee5fefa95e42e9b4804b4d68e130304158"><code>87348ce</code></a> Add 503 warning when uploading to the same artifact</li> <li>See full diff in <a href="https://github.com/actions/upload-artifact/compare/v2...v3">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) Dependabot will merge this PR once it's up-to-date and CI passes on it, as requested by @RomainMuller. [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>
Bumps [aws-actions/stale-issue-cleanup](https://github.com/aws-actions/stale-issue-cleanup) from 4 to 5. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/aws-actions/stale-issue-cleanup/releases">aws-actions/stale-issue-cleanup's releases</a>.</em></p> <blockquote> <h2>v5 release</h2> <h2>What's Changed</h2> <ul> <li>Skip marking issue as stale if the stale message is empty. by <a href="https://github.com/ashishdhingra"><code>@ashishdhingra</code></a> in <a href="https://github-redirect.dependabot.com/aws-actions/stale-issue-cleanup/pull/142">aws-actions/stale-issue-cleanup#142</a></li> </ul> <hr /> <ul> <li>Update dependabot config, checks, and lints by <a href="https://github.com/kellertk"><code>@kellertk</code></a> in <a href="https://github-redirect.dependabot.com/aws-actions/stale-issue-cleanup/pull/52">aws-actions/stale-issue-cleanup#52</a></li> <li>build(deps): bump dateformat from 3.0.3 to 4.4.1 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/aws-actions/stale-issue-cleanup/pull/53">aws-actions/stale-issue-cleanup#53</a></li> <li>Update deps by <a href="https://github.com/kellertk"><code>@kellertk</code></a> in <a href="https://github-redirect.dependabot.com/aws-actions/stale-issue-cleanup/pull/59">aws-actions/stale-issue-cleanup#59</a></li> <li>build(deps): bump lodash from 4.17.20 to 4.17.21 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/aws-actions/stale-issue-cleanup/pull/84">aws-actions/stale-issue-cleanup#84</a></li> <li>build(deps): bump hosted-git-info from 2.8.8 to 2.8.9 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/aws-actions/stale-issue-cleanup/pull/85">aws-actions/stale-issue-cleanup#85</a></li> <li>build(deps-dev): bump eslint-plugin-prettier from 3.3.0 to 3.4.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/aws-actions/stale-issue-cleanup/pull/80">aws-actions/stale-issue-cleanup#80</a></li> <li>build(deps-dev): bump eslint-config-prettier from 6.15.0 to 8.3.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/aws-actions/stale-issue-cleanup/pull/81">aws-actions/stale-issue-cleanup#81</a></li> <li>build(deps): bump ws from 7.4.1 to 7.4.6 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/aws-actions/stale-issue-cleanup/pull/89">aws-actions/stale-issue-cleanup#89</a></li> <li>build(deps): bump glob-parent from 5.1.1 to 5.1.2 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/aws-actions/stale-issue-cleanup/pull/93">aws-actions/stale-issue-cleanup#93</a></li> <li>build(deps-dev): bump eslint from 7.16.0 to 7.32.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/aws-actions/stale-issue-cleanup/pull/102">aws-actions/stale-issue-cleanup#102</a></li> <li>build(deps): bump path-parse from 1.0.6 to 1.0.7 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/aws-actions/stale-issue-cleanup/pull/104">aws-actions/stale-issue-cleanup#104</a></li> <li>Finish implementation of ancient PR message by <a href="https://github.com/Plabick"><code>@Plabick</code></a> in <a href="https://github-redirect.dependabot.com/aws-actions/stale-issue-cleanup/pull/95">aws-actions/stale-issue-cleanup#95</a></li> <li>build(deps): bump tmpl from 1.0.4 to 1.0.5 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/aws-actions/stale-issue-cleanup/pull/112">aws-actions/stale-issue-cleanup#112</a></li> <li>build(deps): bump ansi-regex from 5.0.0 to 5.0.1 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/aws-actions/stale-issue-cleanup/pull/116">aws-actions/stale-issue-cleanup#116</a></li> <li>build(deps-dev): bump jest from 26.6.3 to 27.3.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/aws-actions/stale-issue-cleanup/pull/119">aws-actions/stale-issue-cleanup#119</a></li> <li>build(deps-dev): bump nock from 13.0.5 to 13.1.3 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/aws-actions/stale-issue-cleanup/pull/106">aws-actions/stale-issue-cleanup#106</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/Plabick"><code>@Plabick</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/aws-actions/stale-issue-cleanup/pull/95">aws-actions/stale-issue-cleanup#95</a></li> <li><a href="https://github.com/ashishdhingra"><code>@ashishdhingra</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/aws-actions/stale-issue-cleanup/pull/142">aws-actions/stale-issue-cleanup#142</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/aws-actions/stale-issue-cleanup/compare/v4...v5">https://github.com/aws-actions/stale-issue-cleanup/compare/v4...v5</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/aws-actions/stale-issue-cleanup/commit/e1cf8a5d54b4ff316c76f5356079d3a8df84137e"><code>e1cf8a5</code></a> Skip marking issue as stale if the stale message is empty. (<a href="https://github-redirect.dependabot.com/aws-actions/stale-issue-cleanup/issues/142">#142</a>)</li> <li><a href="https://github.com/aws-actions/stale-issue-cleanup/commit/cd68c8d094b50ca65e5644e0dcd2f0a46b5b64fb"><code>cd68c8d</code></a> build(deps-dev): bump nock from 13.0.5 to 13.1.3 (<a href="https://github-redirect.dependabot.com/aws-actions/stale-issue-cleanup/issues/106">#106</a>)</li> <li><a href="https://github.com/aws-actions/stale-issue-cleanup/commit/7f39252a91aa943938c229c7743ba04d5cc53ad5"><code>7f39252</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/aws-actions/stale-issue-cleanup/issues/119">#119</a> from aws-actions/dependabot/npm_and_yarn/jest-27.3.0</li> <li><a href="https://github.com/aws-actions/stale-issue-cleanup/commit/cd10ed370c5d14c4f3ce3bb273afcf4ae2a64b53"><code>cd10ed3</code></a> build(deps-dev): bump jest from 26.6.3 to 27.3.0</li> <li><a href="https://github.com/aws-actions/stale-issue-cleanup/commit/555fd43e13844bc9e6e03e5e398f296fd46081dd"><code>555fd43</code></a> build(deps): bump ansi-regex from 5.0.0 to 5.0.1 (<a href="https://github-redirect.dependabot.com/aws-actions/stale-issue-cleanup/issues/116">#116</a>)</li> <li><a href="https://github.com/aws-actions/stale-issue-cleanup/commit/e4df8b211428eb7da7fe772d802ee27a192939e6"><code>e4df8b2</code></a> build(deps): bump tmpl from 1.0.4 to 1.0.5 (<a href="https://github-redirect.dependabot.com/aws-actions/stale-issue-cleanup/issues/112">#112</a>)</li> <li><a href="https://github.com/aws-actions/stale-issue-cleanup/commit/57e400abd8dc641670afb665fd2c2d5b83cba7de"><code>57e400a</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/aws-actions/stale-issue-cleanup/issues/95">#95</a> from Plabick/main</li> <li><a href="https://github.com/aws-actions/stale-issue-cleanup/commit/de23c4f041dce66cc40c74eeefddcf6c9d52e100"><code>de23c4f</code></a> Merge branch 'main' into main</li> <li><a href="https://github.com/aws-actions/stale-issue-cleanup/commit/3f7402a8d2f5d28bd8f0567f8c29a3105861297b"><code>3f7402a</code></a> build(deps-dev): bump eslint from 7.16.0 to 7.32.0</li> <li><a href="https://github.com/aws-actions/stale-issue-cleanup/commit/f8f7a1390e0c8e65db4eb2270ab29d4b7abb0fec"><code>f8f7a13</code></a> Update README.md</li> <li>Additional commits viewable in <a href="https://github.com/aws-actions/stale-issue-cleanup/compare/v4...v5">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) Dependabot will merge this PR once it's up-to-date and CI passes on it, as requested by @RomainMuller. [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>
Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 2 to 3. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/actions/download-artifact/releases">actions/download-artifact's releases</a>.</em></p> <blockquote> <h2>v3.0.0</h2> <h2>What's Changed</h2> <ul> <li>Update default runtime to node16 (<a href="https://github-redirect.dependabot.com/actions/download-artifact/pull/134">actions/download-artifact#134</a>)</li> <li>Update package-lock.json file version to 2 (<a href="https://github-redirect.dependabot.com/actions/download-artifact/pull/136">actions/download-artifact#136</a>)</li> </ul> <h3>Breaking Changes</h3> <p>With the update to Node 16, all scripts will now be run with Node 16 rather than Node 12.</p> <h2>v2.1.0 Download Artifact</h2> <ul> <li>Improved output & logging</li> <li>Fixed issue where downloading all artifacts could cause display percentages to be over 100%</li> <li>Various small bug fixes & improvements</li> </ul> <h2>v2.0.10</h2> <ul> <li>Retry on HTTP 500 responses from the service</li> </ul> <h2>v2.0.9</h2> <ul> <li>Fixes to proxy related issues</li> </ul> <h2>v2.0.8</h2> <ul> <li>Improvements to retryability if an error is encountered during artifact download</li> </ul> <h2>v2.0.7 download-artifact</h2> <ul> <li>Improved download retry-ability if a partial download is encountered</li> </ul> <h2>v2.0.6</h2> <p>Update actions/core NPM package that is used internally</p> <h2>v2.0.5</h2> <ul> <li>Add Third Party License Information</li> </ul> <h2>v2.0.4</h2> <ul> <li>Use the latest version of the <code>@actions/artifact</code> NPM package</li> </ul> <h2>v2.0.3</h2> <ul> <li>Misc improvements</li> </ul> <h2>v2.0.2</h2> <ul> <li>Support for tilde expansion</li> </ul> <h2>v2.0.1</h2> <ul> <li>Download path output</li> <li>Improved logging</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/actions/download-artifact/commit/fb598a63ae348fa914e94cd0ff38f362e927b741"><code>fb598a6</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/actions/download-artifact/issues/136">#136</a> from actions/jtamsut/update-lockfile-version</li> <li><a href="https://github.com/actions/download-artifact/commit/a4a09c5d7eb5932e0e6c4e77a434738189a24f1b"><code>a4a09c5</code></a> regenerate index.js</li> <li><a href="https://github.com/actions/download-artifact/commit/9acf51df7946118a04918663acc5d955f49de177"><code>9acf51d</code></a> regenerate package lock</li> <li><a href="https://github.com/actions/download-artifact/commit/882107232564f8bc8c5083706e009246f11aa871"><code>8821072</code></a> upgrade artifact version</li> <li><a href="https://github.com/actions/download-artifact/commit/b8bbd3b64f298f12cfabf7d85ee4e716714eae3b"><code>b8bbd3b</code></a> regenerate lockfile</li> <li><a href="https://github.com/actions/download-artifact/commit/6ee3d963e5a7ed7dac02925e126c37e459c36aa6"><code>6ee3d96</code></a> revert artifact version</li> <li><a href="https://github.com/actions/download-artifact/commit/d4793f4e27ec52069836c96d310f815ffa48176c"><code>d4793f4</code></a> update docs for v3</li> <li><a href="https://github.com/actions/download-artifact/commit/2d338d2145c33c497f1f4f574ca1eb88e1061a8e"><code>2d338d2</code></a> upgrade package to v3</li> <li><a href="https://github.com/actions/download-artifact/commit/360d0830b5796c983178d8073e39063e8d32bc46"><code>360d083</code></a> update dependency on artifact lib</li> <li><a href="https://github.com/actions/download-artifact/commit/d9b73cccacd09ac21cc34b82578e6cbb1b4e2539"><code>d9b73cc</code></a> update lock file</li> <li>Additional commits viewable in <a href="https://github.com/actions/download-artifact/compare/v2...v3">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) Dependabot will merge this PR once it's up-to-date and CI passes on it, as requested by @RomainMuller. [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>
This bug is due to a crazy interaction between the `publication` module, the `__all__` array, and imports we might generate to do type checking in a package that uses submodules. Context ------- Here's what you need to know: - `__all__` is normally used to define the symbols and submodules that should be imported when a consumer does `from mymod import *`. - `publication` is used to hide non-public symbols from library consumers. It will move all symbols that are NOT in `__all__` to a `_private` submodule at runtime (it's overloading `__all__` a little here, but this seems generally okay). - We generate `imports` at the top of the file for the modules that are referenced in a module, so that we can use them in type annotations. Example ------- This is what the currently generated code for the `aws_cdk` module (of CDK's v2 library) currently (roughly) looks like: ```python import publication from .cloud_assembly_schema import AmiContextQuery as _AmiContextQuery_74bf4b1b __all__ = ['Annotations', 'App', ..., 'ValidationResults'] publication.publish() from . import aws_s3 from . import cloud_assembly_schema '...' ``` Given this setup, the following happens: ``` $ python3 Python 3.9.5 (default, Jun 27 2021, 10:29:41) >>> import aws_cdk >>> print(aws_cdk.aws_s3) <module 'aws_cdk.aws_s3' from '.../aws_cdk/aws_s3/__init__.py'> >>> print(aws_cdk.cloud_assembly_schema) Traceback (most recent call last): File "<stdin>", line 1, in <module> AttributeError: module 'aws_cdk' has no attribute 'cloud_assembly_schema' ``` Explanation ----------- Why does this happen? - `__all__` does not contain any submodules - When `publication.publish()` is called, all symbols in the calling namespace that are missing from `__all__` are hidden. - Crucially, this *does* include `cloud_assembly_schema` (because we imported that submodule to import some symbols for type checking purposes) but it doesn't include modules that haven't been imported yet. - Most modules get imported *after* `publication.publish()` is called, and so are not subject to hiding anymore. This is why we never noticed this problem before. - Every module only gets imported once, so even though we generate a second `from . import cloud_assembly_schema` line underneath `publication.publish()`, at that point the line doesn't do anything anymore. Solution -------- Potential solutions are: - Add submodules to `__all__`. - Remove the call to `publication.publish()`. - Make a variant of `publication` that doesn't hide submodules. - Don't generate actual imports for the type annotations. This PR picks the first solution, as it seems simplest. The only downside would have been that `import *` would then start importing all of the CDKv2 library, but that's happening already anyway because of all the `import`s we generate ourselves.
aws-cdk-automation
added
the
pr/no-squash
rix0rrr
approved these changes
Apr 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See CHANGELOG