fix(pacmak): add 'silly' loglevel for command output #3125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pacmak outputs both the command-line commands as well as stdout/stderr for those commands under the `verbose` loglevel. That's too much at one log level: I definitely want to know about the commands without getting spammed with all the command outputs. Introduce a new loglevel, `silly`, and move the command output to that level. Also remove a log line from `npmPack` that is redundant with the log line that prints the command that's going to be executed.
kaizencc
approved these changes
Nov 5, 2021
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
|
Merging (with squash)... |
|
Merging (with squash)... |
|
Merging (with squash)... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pacmak outputs both the command-line commands as well as stdout/stderr
for those commands under the
verboseloglevel.That's too much at one log level: I definitely want to know about the
commands without getting spammed with all the command outputs.
Introduce a new loglevel,
silly, and move the command output tothat level.
Also remove a log line from
npmPackthat is redundant with thelog line that prints the command that's going to be executed.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.