Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rosetta): hangs on 'markdown' command when a file is provided #2871

Merged
merged 2 commits into from
Jun 3, 2021

Conversation

nija-at
Copy link
Contributor

@nija-at nija-at commented Jun 3, 2021

This is caused due to a mismatch between the command declaration where
the argument is named 'FILE' and the positional declaration where the
parameter is named 'file'.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

…a positional argument

This is caused due to a mismatch between the command declaration where
the argument is named 'FILE' and the positional declaration where the
parameter is named 'file'.
@nija-at nija-at requested review from RomainMuller, MrArnoldPalmer and a team June 3, 2021 10:53
@nija-at nija-at self-assigned this Jun 3, 2021
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jun 3, 2021
Copy link
Contributor

@RomainMuller RomainMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dope thanks!

@mergify
Copy link
Contributor

mergify bot commented Jun 3, 2021

Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it!

@mergify mergify bot added the pr/ready-to-merge This PR is ready to be merged. label Jun 3, 2021
@mergify
Copy link
Contributor

mergify bot commented Jun 3, 2021

Merging (with squash)...

@mergify mergify bot merged commit e538b36 into main Jun 3, 2021
@mergify mergify bot deleted the nija-at/rosetta-yargs branch June 3, 2021 15:41
@mergify
Copy link
Contributor

mergify bot commented Jun 3, 2021

Merging (with squash)...

@mergify mergify bot removed the pr/ready-to-merge This PR is ready to be merged. label Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants