feat(superchain): also build a superchain image with Node 14 #2741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For CDKv2, we want to require (and test) against a newer version of
Node. We've attempted to build multiple Node versions into a single
Docker image, but because we cannot control the entrypoint there is no
reliable way of switching between the Node versions at execution time.
Therefore, we will now build two versions of the "superchain" image.
The Node version built into each is controlled by the `NODE_VERSION`
build argument.
Workflow has been changed to build and push the following images:
* Nightlies:
* `jsii/superchain:node10-nightly`
* `jsii/superchain:node14-nightly`
* `jsii/superchain:nightly` will remain an alias for `:node10-nightly`
* Releases:
* `jsii/superchain:node10`
* `jsii/superchain:node14`
* `jsii/superchain:latest` will remain an alias for `:node10`.
(Multiple images are built in a `for` loop instead of having parallel
workflows because as far as I know there's no way to parameterize the
rather complex GitHub Action Workflow, so the alternative would be
copy/pasting which I'd rather not do).
superchain/README.md
Outdated
Comment on lines
16
to
17
| `Javascript` | `node >= 10.19.0` with `npm >= 6.13.4` (default) | ||
| | OR `node >= 14.16.0` with `npm >= 6.14.11` (`--build-arg NODE_VERSION=14`) |
There was a problem hiding this comment.
This won't render properly... Seems like the rendering engine does not like when the first column is empty.
Also - you don't want to make this relative to --build-arg, instead refer to the tag names.
Perhaps we should actually extract the node and npm info to a sub-section - and in the table mention this is tag-dependent, and link to it?
RomainMuller
approved these changes
Mar 25, 2021
| --network=host \ | ||
| -v${{ github.workspace }}:${{ github.workspace }} \ | ||
| -w${{ github.workspace }} \ | ||
| "jsii/superchain:node${{ matrix.node }}-nightly" \ |
There was a problem hiding this comment.
You could have left ' here - the ${{}} stuff gets interpolated before the job runs.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For CDKv2, we want to require (and test) against a newer version of
Node. We've attempted to build multiple Node versions into a single
Docker image, but because we cannot control the entrypoint there is no
reliable way of switching between the Node versions at execution time.
Therefore, we will now build two versions of the "superchain" image.
The Node version built into each is controlled by the
NODE_VERSIONbuild argument.
Workflow has been changed to build and push the following images:
jsii/superchain:node10-nightlyjsii/superchain:node14-nightlyjsii/superchain:nightlywill remain an alias for:node10-nightlyjsii/superchain:node10jsii/superchain:node14jsii/superchain:latestwill remain an alias for:node10.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.