Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(go): invalid output for multi-line @return and @deprecated comments #2462

Merged
merged 5 commits into from
Jan 21, 2021

Conversation

eladb
Copy link
Contributor

@eladb eladb commented Jan 21, 2021

Split multi-line comments and prefix with // so they are rendered correctly.

Fixes #2457


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Split multi-line comments and prefix with `//` so they are rendered correctly.

Fixes #2457
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jan 21, 2021
Copy link
Contributor

@RomainMuller RomainMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am somehow irked by the trailing whitespace, which is so easy to get rid of...

packages/jsii-calc/lib/documented.ts Show resolved Hide resolved
packages/jsii-pacmak/lib/targets/go/documentation.ts Outdated Show resolved Hide resolved
@RomainMuller RomainMuller requested review from a team and removed request for MrArnoldPalmer January 21, 2021 11:59
@eladb eladb requested a review from RomainMuller January 21, 2021 12:08
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-5lHf64IXfvmr
  • Commit ID: 89fbbba
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Jan 21, 2021

Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it!

@mergify mergify bot added the pr/ready-to-merge This PR is ready to be merged. label Jan 21, 2021
@mergify mergify bot merged commit 590681a into main Jan 21, 2021
@mergify mergify bot deleted the benisrae/fix-go-multiline branch January 21, 2021 15:41
@mergify
Copy link
Contributor

mergify bot commented Jan 21, 2021

Merging (with squash)...

@mergify mergify bot removed the pr/ready-to-merge This PR is ready to be merged. label Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Go: multi-line comments result in invalid go code
3 participants